Skip to content

Commit

Permalink
Update urls github.com/uber -> github.com/visgl (visgl#4505)
Browse files Browse the repository at this point in the history
* Update urls github.com/uber -> github.com/visgl
  • Loading branch information
1chandu authored Apr 16, 2020
1 parent d4f5150 commit 7b3b615
Show file tree
Hide file tree
Showing 224 changed files with 366 additions and 377 deletions.
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/question.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,6 @@ assignees: ''
---

<!-- Ask a question that is not answered in our (documentation)[http://deck.gl/#/documentation]. -->
<!-- Also check answered issues tagged as (FAQ)[https://github.com/uber/deck.gl/issues?utf8=%E2%9C%93&q=is%3Aissue+label%3Afaq]-->
<!-- Also check answered issues tagged as (FAQ)[https://github.com/visgl/deck.gl/issues?utf8=%E2%9C%93&q=is%3Aissue+label%3Afaq]-->

<!-- Suggest an improvement or clarification in our documentation. -->
4 changes: 2 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2397,7 +2397,7 @@ haders

#### [4.1.0] - 2017-7-27 Minor deck.gl Release

For details see [What's New](https://github.com/uber/deck.gl/blob/5.0-release/docs/whats-new.md)
For details see [What's New](https://github.com/visgl/deck.gl/blob/5.0-release/docs/whats-new.md)


### deck.gl v4.1 Beta Releases
Expand Down Expand Up @@ -3083,7 +3083,7 @@ For details see [What's New](docs/whats-new.md)
- Retina display support
- Performance refactoring
- Switched the underlying rendering framework to
[luma.gl](https://github.com/uber/luma.gl)
[luma.gl](https://github.com/visgl/luma.gl)
- Fixed picking on retina/regular display

## deck.gl v1
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ Deck.gl is designed to be highly customizable. All layers come with flexible API
```

- [Get started](/docs/get-started/using-standalone.md#using-the-scripting-api)
- [Full examples](https://github.com/uber/deck.gl/tree/master/examples/get-started/scripting)
- [Full examples](https://github.com/visgl/deck.gl/tree/master/examples/get-started/scripting)

### NPM Module

Expand Down
4 changes: 2 additions & 2 deletions bindings/pydeck/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -103,15 +103,15 @@ Error handling will be expanded in future versions of pydeck.

### Issues

If you encounter an issue, file it in the [deck.gl issues page](https://github.com/uber/deck.gl/issues/new?assignees=&labels=question&template=question.md&title=)
If you encounter an issue, file it in the [deck.gl issues page](https://github.com/visgl/deck.gl/issues/new?assignees=&labels=question&template=question.md&title=)
and include your browser's console output, if any.


### Installation from source

```bash
# Clone the deck.gl repo
git clone https://github.com/uber/deck.gl/
git clone https://github.com/visgl/deck.gl/

# Navigate to the pydeck module
cd deck.gl/bindings/pydeck
Expand Down
2 changes: 1 addition & 1 deletion bindings/pydeck/docs/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ Configure the lighting within a visualization.

Currently, pydeck will **not** raise an error on incorrect or omitted Layer arguments.
If nothing renders in your viewport, check your browser's `developer console <https://javascript.info/devtools>`__
or review the layer catalog. You are encouraged to file an issue by clicking `here <https://github.com/uber/deck.gl/issues/new?assignees=&labels=bug&template=bug-report.md&title=pydeck:>`__
or review the layer catalog. You are encouraged to file an issue by clicking `here <https://github.com/visgl/deck.gl/issues/new?assignees=&labels=bug&template=bug-report.md&title=pydeck:>`__
and mention ``pydeck`` in the title.


Expand Down
2 changes: 1 addition & 1 deletion bindings/pydeck/docs/installation.rst
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ If you want to install the library from its source:

.. code-block:: bash
git clone https://github.com/uber/deck.gl
git clone https://github.com/visgl/deck.gl
cd deck.gl/bindings/pydeck
make pre-init
. env/bin/activate
Expand Down
12 changes: 6 additions & 6 deletions bindings/pydeck/docs/layer.rst
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,14 @@ Layer Overview and Examples

:class:`pydeck.bindings.layer.Layer` represents a kind of data visualization, like a scatterplot
or a hexbin chart.
The full `deck.gl layer catalog <https://github.com/uber/deck.gl/tree/master/docs/layers#deckgl-layer-catalog-overview>`__ is accessible via pydeck.
The full `deck.gl layer catalog <https://github.com/visgl/deck.gl/tree/master/docs/layers#deckgl-layer-catalog-overview>`__ is accessible via pydeck.
This page will provide more examples of how to utilize the deck.gl catalog in Python via pydeck.

.. warning:: **pydeck does not currently raise an error on
incorrect or omitted layer arguments**. If nothing renders in
your viewport, check your browser's
`developer console <https://javascript.info/devtools>`__ or review the layer catalog.
If you're still stuck, file an issue with clicking `here <https://github.com/uber/deck.gl/issues/new?assignees=&labels=bug&template=bug-report.md&title=>`__.
If you're still stuck, file an issue with clicking `here <https://github.com/visgl/deck.gl/issues/new?assignees=&labels=bug&template=bug-report.md&title=>`__.

.. autoclass:: pydeck.bindings.layer.Layer

Expand All @@ -20,7 +20,7 @@ Understanding keyword arguments in pydeck layers

Keyword arguments vary by layer. A catalog of available layers in
deck.gl is viewable
`in the deck.gl layer catalog <https://github.com/uber/deck.gl/tree/master/docs/layers#deckgl-layer-catalog-overview>`__.
`in the deck.gl layer catalog <https://github.com/visgl/deck.gl/tree/master/docs/layers#deckgl-layer-catalog-overview>`__.

A few important observations:

Expand Down Expand Up @@ -52,7 +52,7 @@ HexagonLayer <https://deck.gl/#/examples/core-layers/hexagon-layer>`__:
import pydeck as pdk
UK_ACCIDENTS_DATA = 'https://raw.githubusercontent.com/uber-common/deck.gl-data/master/examples/3d-heatmap/heatmap-data.csv'
UK_ACCIDENTS_DATA = 'https://raw.githubusercontent.com/visgl/deck.gl-data/master/examples/3d-heatmap/heatmap-data.csv'
layer = pdk.Layer(
'HexagonLayer', # `type` positional argument is here
Expand Down Expand Up @@ -110,7 +110,7 @@ One particularly powerful feature of pydeck is an in-built Javascript
expression parser that can process a limited subset of Javascript–no
functions are allowed, but data accessors, Boolean conditions, inline
logical statements, arithmetic operations, and arrays are available.
The full details on the deck.gl expression parser are viewable `here <https://github.com/uber/deck.gl/blob/master/docs/api-reference/json/conversion-reference.md>`__.
The full details on the deck.gl expression parser are viewable `here <https://github.com/visgl/deck.gl/blob/master/docs/api-reference/json/conversion-reference.md>`__.

To demonstrate the expression parser, change the color input in
``get_fill_color`` to a string:
Expand Down Expand Up @@ -229,7 +229,7 @@ Below, an example combining the expression parser with multiple layers, based on
import pydeck
DATA_URL = "https://raw.githubusercontent.com/uber-common/deck.gl-data/master/examples/geojson/vancouver-blocks.json"
DATA_URL = "https://raw.githubusercontent.com/visgl/deck.gl-data/master/examples/geojson/vancouver-blocks.json"
LAND_COVER = [[[-123.0, 49.196], [-123.0, 49.324], [-123.306, 49.324], [-123.306, 49.196]]]
INITIAL_VIEW_STATE = pydeck.ViewState(
Expand Down
2 changes: 1 addition & 1 deletion bindings/pydeck/docs/tooltip.rst
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ A full demo is below:
r.to_html()
.. _pickingInfo.object:
https://github.com/uber/deck.gl/blob/master/docs/developer-guide/interactivity.md#the-picking-info-object
https://github.com/visgl/deck.gl/blob/master/docs/developer-guide/interactivity.md#the-picking-info-object
.. _innerHTML:
https://developer.mozilla.org/en-US/docs/Web/API/Element/innerHTML
.. _innerText:
Expand Down
4 changes: 2 additions & 2 deletions bindings/pydeck/examples/01 - Introduction.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"- large-scale updates to data points, like plotting points with motion\n",
"- making beautiful maps\n",
"\n",
"Under the hood, it's powered by the [deck.gl](https://github.com/uber/deck.gl/) JavaScript framework.\n",
"Under the hood, it's powered by the [deck.gl](https://github.com/visgl/deck.gl/) JavaScript framework.\n",
"\n",
"pydeck is strongest when used in tandem with [Pandas](https://pandas.pydata.org/) but doesn't have to be.\n",
"\n",
Expand Down Expand Up @@ -50,7 +50,7 @@
"source": [
"import pandas as pd\n",
"\n",
"UK_ACCIDENTS_DATA = 'https://raw.githubusercontent.com/uber-common/deck.gl-data/master/examples/3d-heatmap/heatmap-data.csv'\n",
"UK_ACCIDENTS_DATA = 'https://raw.githubusercontent.com/visgl/deck.gl-data/master/examples/3d-heatmap/heatmap-data.csv'\n",
"\n",
"pd.read_csv(UK_ACCIDENTS_DATA).head()"
]
Expand Down
4 changes: 2 additions & 2 deletions bindings/pydeck/examples/02 - Scatterplots.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -114,9 +114,9 @@
"\n",
"\n",
"\n",
"**We can specify the layer type as the first argument, the data as the second, and the layer arguments as keywords.** **[ScatterplotLayer](https://github.com/uber/deck.gl/blob/master/docs/layers/scatterplot-layer.md)** is one of a list of layers available in the deck.gl core library. We'll also provide a header to list the year using some built-in Jupyter notebook tools.\n",
"**We can specify the layer type as the first argument, the data as the second, and the layer arguments as keywords.** **[ScatterplotLayer](https://github.com/visgl/deck.gl/blob/master/docs/layers/scatterplot-layer.md)** is one of a list of layers available in the deck.gl core library. We'll also provide a header to list the year using some built-in Jupyter notebook tools.\n",
"\n",
"For a list of other layers, see the [deck.gl documentation](https://github.com/uber/deck.gl/tree/master/docs/layers#deckgl-layer-catalog-overview). Remember that deck.gl is a JavaScript library and not a Python one, so the documentation may differ for some kinds of terminology and functionality (e.g., pydeck doesn't support passing functions as arguments but this is a common occurrence within deck.gl)."
"For a list of other layers, see the [deck.gl documentation](https://github.com/visgl/deck.gl/tree/master/docs/layers#deckgl-layer-catalog-overview). Remember that deck.gl is a JavaScript library and not a Python one, so the documentation may differ for some kinds of terminology and functionality (e.g., pydeck doesn't support passing functions as arguments but this is a common occurrence within deck.gl)."
]
},
{
Expand Down
2 changes: 1 addition & 1 deletion bindings/pydeck/examples/geojson_layer.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

import pydeck

DATA_URL = "https://raw.githubusercontent.com/uber-common/deck.gl-data/master/examples/geojson/vancouver-blocks.json"
DATA_URL = "https://raw.githubusercontent.com/visgl/deck.gl-data/master/examples/geojson/vancouver-blocks.json"
LAND_COVER = [[[-123.0, 49.196], [-123.0, 49.324], [-123.306, 49.324], [-123.306, 49.196]]]

INITIAL_VIEW_STATE = pydeck.ViewState(latitude=49.254, longitude=-123.13, zoom=11, max_zoom=16, pitch=45, bearing=0)
Expand Down
2 changes: 1 addition & 1 deletion bindings/pydeck/examples/great_circle_layer.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
import pandas as pd

GREAT_CIRCLE_LAYER_DATA = (
"https://raw.githubusercontent.com/uber-common/deck.gl-data/master/website/flights.json" # noqa
"https://raw.githubusercontent.com/visgl/deck.gl-data/master/website/flights.json" # noqa
)

df = pd.read_json(GREAT_CIRCLE_LAYER_DATA)
Expand Down
2 changes: 1 addition & 1 deletion bindings/pydeck/examples/h3_cluster_layer.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
import pandas as pd

H3_CLUSTER_LAYER_DATA = (
"https://raw.githubusercontent.com/uber-common/deck.gl-data/master/website/sf.h3clusters.json" # noqa
"https://raw.githubusercontent.com/visgl/deck.gl-data/master/website/sf.h3clusters.json" # noqa
)

df = pd.read_json(H3_CLUSTER_LAYER_DATA)
Expand Down
2 changes: 1 addition & 1 deletion bindings/pydeck/examples/h3_hexagon_layer.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
import pydeck as pdk
import pandas as pd

H3_HEX_DATA = "https://raw.githubusercontent.com/uber-common/deck.gl-data/master/website/sf.h3cells.json"
H3_HEX_DATA = "https://raw.githubusercontent.com/visgl/deck.gl-data/master/website/sf.h3cells.json"

df = pd.read_json(H3_HEX_DATA)

Expand Down
2 changes: 1 addition & 1 deletion bindings/pydeck/examples/hexagon_layer.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
import pydeck as pdk

HEXAGON_LAYER_DATA = (
"https://raw.githubusercontent.com/uber-common/deck.gl-data/master/examples/3d-heatmap/heatmap-data.csv" # noqa
"https://raw.githubusercontent.com/visgl/deck.gl-data/master/examples/3d-heatmap/heatmap-data.csv" # noqa
)

# Define a layer to display on a map
Expand Down
4 changes: 2 additions & 2 deletions bindings/pydeck/examples/line_layer.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
import pydeck

DATA_URL = {
"AIRPORTS": "https://raw.githubusercontent.com/uber-common/deck.gl-data/master/examples/line/airports.json",
"FLIGHT_PATHS": "https://raw.githubusercontent.com/uber-common/deck.gl-data/master/examples/line/heathrow-flights.json", # noqa
"AIRPORTS": "https://raw.githubusercontent.com/visgl/deck.gl-data/master/examples/line/airports.json",
"FLIGHT_PATHS": "https://raw.githubusercontent.com/visgl/deck.gl-data/master/examples/line/heathrow-flights.json", # noqa
}

INITIAL_VIEW_STATE = pydeck.ViewState(latitude=47.65, longitude=7, zoom=4.5, max_zoom=16, pitch=50, bearing=0)
Expand Down
2 changes: 1 addition & 1 deletion bindings/pydeck/examples/path_layer.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
import pydeck
import pandas as pd

DATA_URL = "https://raw.githubusercontent.com/uber-common/deck.gl-data/master/website/bart-lines.json"
DATA_URL = "https://raw.githubusercontent.com/visgl/deck.gl-data/master/website/bart-lines.json"
df = pd.read_json(DATA_URL)


Expand Down
2 changes: 1 addition & 1 deletion bindings/pydeck/examples/polygon_layer.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
import pandas as pd

# Load in the JSON data
DATA_URL = "https://raw.githubusercontent.com/uber-common/deck.gl-data/master/examples/geojson/vancouver-blocks.json"
DATA_URL = "https://raw.githubusercontent.com/visgl/deck.gl-data/master/examples/geojson/vancouver-blocks.json"
json = pd.read_json(DATA_URL)
df = pd.DataFrame()

Expand Down
2 changes: 1 addition & 1 deletion bindings/pydeck/examples/s2_layer.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
import pydeck as pdk
import pandas as pd

S2_LAYER_DATA = "https://raw.githubusercontent.com/uber-common/deck.gl-data/master/website/sf.s2cells.json" # noqa
S2_LAYER_DATA = "https://raw.githubusercontent.com/visgl/deck.gl-data/master/website/sf.s2cells.json" # noqa

df = pd.read_json(S2_LAYER_DATA)

Expand Down
2 changes: 1 addition & 1 deletion bindings/pydeck/examples/scatterplot_layer.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
import pandas as pd
import math

SCATTERPLOT_LAYER_DATA = "https://raw.githubusercontent.com/uber-common/deck.gl-data/master/website/bart-stations.json"
SCATTERPLOT_LAYER_DATA = "https://raw.githubusercontent.com/visgl/deck.gl-data/master/website/bart-stations.json"
df = pd.read_json(SCATTERPLOT_LAYER_DATA)

# Use pandas to calculate additional data
Expand Down
2 changes: 1 addition & 1 deletion bindings/pydeck/examples/screengrid_layer.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
import pandas as pd

SCREEN_GRID_LAYER_DATA = (
"https://raw.githubusercontent.com/uber-common/deck.gl-data/master/website/sf-bike-parking.json" # noqa
"https://raw.githubusercontent.com/visgl/deck.gl-data/master/website/sf-bike-parking.json" # noqa
)
df = pd.read_json(SCREEN_GRID_LAYER_DATA)

Expand Down
2 changes: 1 addition & 1 deletion bindings/pydeck/examples/text_layer.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
import pydeck as pdk
import pandas as pd

TEXT_LAYER_DATA = "https://raw.githubusercontent.com/uber-common/deck.gl-data/master/website/bart-stations.json" # noqa
TEXT_LAYER_DATA = "https://raw.githubusercontent.com/visgl/deck.gl-data/master/website/bart-stations.json" # noqa
df = pd.read_json(TEXT_LAYER_DATA)

# Define a layer to display on a map
Expand Down
2 changes: 1 addition & 1 deletion bindings/pydeck/examples/trips_layer.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
import pydeck as pdk
import pandas as pd

TRIPS_LAYER_DATA = "https://raw.githubusercontent.com/uber-common/deck.gl-data/master/website/sf.trips.json" # noqa
TRIPS_LAYER_DATA = "https://raw.githubusercontent.com/visgl/deck.gl-data/master/website/sf.trips.json" # noqa

df = pd.read_json(TRIPS_LAYER_DATA)

Expand Down
2 changes: 1 addition & 1 deletion bindings/pydeck/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ def run(self):
},
author="Andrew Duberstein",
author_email="ajduberstein@gmail.com",
url="https://github.com/uber/deck.gl/tree/master/bindings/pydeck",
url="https://github.com/visgl/deck.gl/tree/master/bindings/pydeck",
keywords=["data", "visualization", "graphics", "GIS", "maps"],
classifiers=[
"Intended Audience :: Developers",
Expand Down
2 changes: 1 addition & 1 deletion bindings/pydeck/tests/bindings/pydeck_examples/minimal.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ def create_minimal_test_object():
)
layer = Layer(
"HexagonLayer",
"https://raw.githubusercontent.com/uber-common/deck.gl-data/master/examples/3d-heatmap/heatmap-data.csv",
"https://raw.githubusercontent.com/visgl/deck.gl-data/master/examples/3d-heatmap/heatmap-data.csv",
id="heatmap",
elevation_scale=50,
elevation_range=[0, 3000],
Expand Down
2 changes: 1 addition & 1 deletion bindings/pydeck/tests/fixtures/minimal.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
{
"@@type": "HexagonLayer",
"coverage": 1,
"data": "https://raw.githubusercontent.com/uber-common/deck.gl-data/master/examples/3d-heatmap/heatmap-data.csv",
"data": "https://raw.githubusercontent.com/visgl/deck.gl-data/master/examples/3d-heatmap/heatmap-data.csv",
"elevationRange": [
0,
3000
Expand Down
4 changes: 2 additions & 2 deletions dev-docs/RFCs/proposals/projection-mode-improvements-rfc.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
* **Status**: Draft

Notes:
* See discussions at end of [Issue 677](https://github.com/uber/deck.gl/issues/677)
* Also see [PR 904](https://github.com/uber/deck.gl/pull/904)
* See discussions at end of [Issue 677](https://github.com/visgl/deck.gl/issues/677)
* Also see [PR 904](https://github.com/visgl/deck.gl/pull/904)


## Summary
Expand Down
4 changes: 2 additions & 2 deletions dev-docs/RFCs/proposals/pydeck-interactive-api-rfc.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
References:
- [deck.gl Transport protocol](https://docs.google.com/presentation/d/1fzSHJxstSfNQe8VCtLLZvQ8D3OuJAfS7_LqPg0QPPvc)
- [ipywidgets.observe()](https://ipywidgets.readthedocs.io/en/latest/examples/Widget%20Events.html)
- [pydeck example: reading back selection](https://github.com/uber/deck.gl/blob/master/bindings/pydeck/examples/03%20-%20Using%20pydeck%20to%20manipulate%20data.ipynb)
- [deck.gl Feature Request: Add onClick event listener in pydeck](https://github.com/uber/deck.gl/issues/3864)
- [pydeck example: reading back selection](https://github.com/visgl/deck.gl/blob/master/bindings/pydeck/examples/03%20-%20Using%20pydeck%20to%20manipulate%20data.ipynb)
- [deck.gl Feature Request: Add onClick event listener in pydeck](https://github.com/visgl/deck.gl/issues/3864)

## Overview

Expand Down
4 changes: 2 additions & 2 deletions dev-docs/RFCs/proposals/pydeck-module-loading-rfc.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ One of the major advantages of deck.gl is that it is a toolbox on top of which a

## Background

Layer injection in pydeck is currently done [here](https://github.com/uber/deck.gl/blob/master/modules/jupyter-widget/src/create-deck.js). As can be seen it is a static process that depends on the layer modules being bundled during the pydeck build process.
Layer injection in pydeck is currently done [here](https://github.com/visgl/deck.gl/blob/master/modules/jupyter-widget/src/create-deck.js). As can be seen it is a static process that depends on the layer modules being bundled during the pydeck build process.

## Prior Art

Expand All @@ -29,7 +29,7 @@ commonjs and AMD are two ways to package up JS modules so that they can be impor

### Dynamic script loading

loaders.gl has implemented a [dynamic script loading system](https://github.com/uber-web/loaders.gl/tree/master/modules/loader-utils/src/lib/library-utils) to support optional, on-demand loading of large loader libraries and worker threads.
loaders.gl has implemented a [dynamic script loading system](https://github.com/visgl/loaders.gl/tree/master/modules/loader-utils/src/lib/library-utils) to support optional, on-demand loading of large loader libraries and worker threads.

This system could be copied / generalized to deck/pydeck so that a list of additional layer module URLs could be provided to pydeck and loaded dynamically.

Expand Down
2 changes: 1 addition & 1 deletion dev-docs/RFCs/proposals/render-layer-to-texture-rfc.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* **Date**: Sep, 2017
* **Status**: Proposal

* See [Issue](https://github.com/uber/deck.gl/issues/908)
* See [Issue](https://github.com/visgl/deck.gl/issues/908)


## Motivation
Expand Down
2 changes: 1 addition & 1 deletion dev-docs/RFCs/v4.1/event-handling-rfc.md
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ If Touch handlers not provided, touch events will call Mouse event handlers, sim
## Remarks

* It is possible that there is an existing npm event handling module on just the right abstraction level that we could use. But we seem to already have implemented what we need several times over so maybe we should just keep ownership of this important piece of the stack, unless integrating with the module in question has a value to developers (familiarity etc)...
* An experiment replacing our EventManager with hammer.js: https://github.com/uber/react-map-gl/compare/hammer?expand=1
* An experiment replacing our EventManager with hammer.js: https://github.com/visgl/react-map-gl/compare/hammer?expand=1
* hammer.js handles pointer events perfectly but is missing wheel and keyboard input. In the above code I extended the built-in PointerEventInput class to add mouse wheel event handler.
* EventManager should use the Factory pattern. Note that neither of the following conditions may end up as requirements, but implementing EventManager as a factory rather than just instantiating each use directly gives us flexibility to handle these and other cases:
* It can maintain a Singleton if necessary, e.g. to manage conflicts that might arise from multiple EventManager instances each attaching handlers to Window for some event types (mousemove, keydown, etc)
Expand Down
2 changes: 1 addition & 1 deletion dev-docs/RFCs/v5.0/auto-highlighting-rfc.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* **Status**: **Implemented**

Notes:
* Please add comments as reviews to the [PR](https://github.com/uber/deck.gl/pull/839)
* Please add comments as reviews to the [PR](https://github.com/visgl/deck.gl/pull/839)


## Overview
Expand Down
2 changes: 1 addition & 1 deletion dev-docs/RFCs/v5.0/first-person-geospatial-viewport-rfc.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
References:
* The initial [Infovis Viewport RFC](../v4.0/non-geospatial-viewports-rfc.md) for deck.gl v4.
* Controller Changes [Controller Architecture RFC](./controller-architecture-rfc.md)
* Initial review in [PR](https://github.com/uber/deck.gl/pull/838)
* Initial review in [PR](https://github.com/visgl/deck.gl/pull/838)


## Overview
Expand Down
Loading

0 comments on commit 7b3b615

Please sign in to comment.