PathLayer: fix rightDeltas attribute generation when using flat verti…

…ces (visgl#2694)
mpearson · Feb 20, 2019 · 21e14e2 · 21e14e2
1 parent 51b6bb9
commit 21e14e2
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/modules/layers/src/path-layer/path-tesselator.js b/modules/layers/src/path-layer/path-tesselator.js
@@ -108,8 +108,9 @@ export default class PathTesselator extends Tesselator {
     let nextPoint;
 
     for (let i = context.vertexStart, ptIndex = 1; ptIndex < numPoints; i++, ptIndex++) {
-      nextPoint = this.getPointOnPath(path, ptIndex + 1);
-      if (!nextPoint) {
+      if (ptIndex + 1 < numPoints) {
+        nextPoint = this.getPointOnPath(path, ptIndex + 1);
+      } else {
         nextPoint = isPathClosed ? this.getPointOnPath(path, 1) : endPoint;
       }
 

diff --git a/test/modules/layers/path-tesselator.spec.js b/test/modules/layers/path-tesselator.spec.js
@@ -104,6 +104,7 @@ test('PathTesselator#constructor', t => {
       );
 
       t.ok(ArrayBuffer.isView(tesselator.get('leftDeltas')), 'PathTesselator.get leftDeltas');
+      t.ok(tesselator.get('leftDeltas').every(Number.isFinite), 'Valid leftDeltas attribute');
       t.deepEquals(
         tesselator.get('leftDeltas').slice(0, 6),
         [0, 0, 0, 1, 1, 0],
@@ -116,6 +117,7 @@ test('PathTesselator#constructor', t => {
         [1, 1, 0, 0, 0, 0],
         'rightDeltas are filled'
       );
+      t.ok(tesselator.get('rightDeltas').every(Number.isFinite), 'Valid rightDeltas attribute');
       t.deepEquals(
         tesselator.get('rightDeltas').slice(-3),
         [1, 1, 0],