Payments for communal services #84
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzaar
requested changes
Jan 15, 2025
Yandex.Checkout.V3/NewPayment.cs
Outdated
| /// <see cref="ReceiverMobileBalance"/>, | ||
| /// <see cref="ReceiverDigitalWallet"/>. | ||
| /// </summary> | ||
| public ReceiverBase Receiver { get; set; } |
There was a problem hiding this comment.
Боюсь, что при получении информации о платеже (GetPayment) Receiver не десериализуется в нужный тип. См. добавленный мной тест.
There was a problem hiding this comment.
Нужно что-то вроде этого: https://stackoverflow.com/a/19308474/1291717
There was a problem hiding this comment.
Добрый день.
Обязательно посмотрю на днях!
There was a problem hiding this comment.
Поправил.
Но пока писал, подумал, имел ли смысл так усложнять, может быть достаточно сделать Receiver с перечислением всех доступных полей?
There was a problem hiding this comment.
@bzaar Доброго времени суток, посмотрите, пожалуйста
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#83
@bzaar посмотрите, пожалуйста, посмотрел документацию, поправил модель, проверил в тестовом кабинете, как будет работать в бою - неизвестно.