Skip to content
This repository has been archived by the owner on Oct 25, 2021. It is now read-only.

Fix Xamarin.Android SDK locations to match the latest paths. #566

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Xamarin.Android SDK locations to match the latest paths. #566

wants to merge 1 commit into from

Conversation

atsushieno
Copy link
Member

Now we have:

bin/
include/
lib/xamarin.android/lib/xbuild
lib/xamarin.android/lib/xbuild/Xamarin/Android (`mandroid` in the past)
lib/xamarin.android/lib/xbuild-frameworks/MonoAndroid/v*
Version*

@atsushieno
Copy link
Member Author

One more thing: removed debug runtime check to not exclude xamarin-android OSS SDK especially on Linux.

@tritao
Copy link
Contributor

tritao commented Jan 14, 2018

This seems to break the build on Windows, can we keep backwards compatibility here?

@jonathanpeppers
Copy link
Member

So the reason this is not working on Windows, is the structure of the OSS zip at: https://jenkins.mono-project.com/view/Xamarin.Android/job/xamarin-android/682/Azure/processDownloadRequest/xamarin-android/oss-xamarin.android_v8.0.0.37_Darwin-x86_64_HEAD_376f684.zip

./bin
./include
./lib
./lib/xbuild
./lib/xbuild/Novell
./lib/xbuild/Xamarin
./lib/xbuild/Xamarin/Android
./lib/xbuild/Xamarin/Android/lib
./lib/xbuild-frameworks
./lib/xbuild-frameworks/MonoAndroid
./lib/xbuild-frameworks/MonoAndroid/v1.0
./lib/xbuild-frameworks/MonoAndroid/v1.0/Facades
./lib/xbuild-frameworks/MonoAndroid/v2.3
./lib/xbuild-frameworks/MonoAndroid/v7.0

Since this is what Embeddinator is bundling, it should work with Embeddinator on NuGet or if you run the Download-Xamarin-Android cake task. There are a decent amount of changes to be done to support both the OSS zip and the system Xamarin.Android. I believe there is some path lookup logic we are using in Xamarin.Android.Build.Tests that could be used (I recently made it work on Windows).

I'm not sure how the macOS CI passed here... Does it run Generate-Android?

@tritao
Copy link
Contributor

tritao commented Jan 16, 2018

Looks like the Travis Cake steps were missing the Android tests, I've sent a PR to add it.

@atsushieno
Copy link
Member Author

Thanks for the insights. Let me get a working e4k environment first, I need it for my local presentation :( Working on patches to come next.

@atsushieno atsushieno mentioned this pull request Jan 17, 2018
Open
@atsushieno atsushieno force-pushed the fix-monodroid-sdk branch 4 times, most recently from fd1eebb to b1e425c Compare January 18, 2018 16:39
@atsushieno
Fix Xamarin.Android SDK locations to match the latest paths.
610426a 
Now we have:

	bin/
	include/
	lib/xamarin.android/lib/xbuild
	lib/xamarin.android/lib/xbuild/Xamarin/Android (`mandroid` in the past)
	lib/xamarin.android/lib/xbuild-frameworks/MonoAndroid/v*
	Version*
@jonathanpeppers
Copy link
Member

@atsushieno I think you got things working on Linux without this PR?

I think reworking things to use the system Xamarin.Android should replace these change. Hopefully I can work on that soonish?

@atsushieno
Copy link
Member Author

Not at all. Things are broken.

@atsushieno
Copy link
Member Author

Why did you close it?

@jonathanpeppers
Copy link
Member

We are trying to cleanup old issues/prs. We can reopen if this PR is still valid and we can get the CI to pass.

@atsushieno
Copy link
Member Author

You didn't actually work on it. Anyone who had the same problem will see my PR and can improve it based on the existing work. You are just hiding your problem.

@atsushieno atsushieno reopened this Mar 27, 2018
@jonathanpeppers
Copy link
Member

We are just closing anything that didn't have activity for a few months, not hiding anything.

Sorry if I wasn't clear,

@atsushieno
Copy link
Member Author

atsushieno commented Mar 27, 2018 •
edited
Loading

In case it's not clear, I had created so many PRsissues that fix various issues and that have been kept untouched. I know there is no one for a while so I just left them, but that also means no one can expect any further bugfix contributions from me.

Base automatically changed from master to main March 9, 2021 10:25
@rolfbjarne rolfbjarne removed their request for review March 9, 2021 12:53
@dalexsoto dalexsoto removed their request for review March 9, 2021 14:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chamons chamons Awaiting requested review from chamons

@jonathanpeppers jonathanpeppers Awaiting requested review from jonathanpeppers jonathanpeppers is a code owner

@spouliot spouliot Awaiting requested review from spouliot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atsushieno @tritao @jonathanpeppers