Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stdlib] [NFC] Fix change UnsafePointer constructors to receive length as a UInt #3923

Open
wants to merge 3 commits into
base: nightly
Choose a base branch
from

Conversation

martinvuyk
Copy link
Contributor

@martinvuyk martinvuyk commented Jan 2, 2025

Fix change UnsafePointer constructors to receive length as a UInt

Signed-off-by: martinvuyk <martin.vuyklop@gmail.com>
@martinvuyk martinvuyk requested a review from a team as a code owner January 2, 2025 14:40
Signed-off-by: martinvuyk <martin.vuyklop@gmail.com>
@martinvuyk martinvuyk changed the title [stdlib] [NFC] Fix add debug_assert for UnsafePointer constructors [stdlib] [NFC] Fix change UnsafePointer constructors to receive length as a UInt Jan 2, 2025
Signed-off-by: martinvuyk <martin.vuyklop@gmail.com>
@JoeLoser JoeLoser requested a review from jackos January 7, 2025 16:25
Copy link
Collaborator

@jackos jackos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks for fixing the naming of ptr as well @martinvuyk

@jackos
Copy link
Collaborator

jackos commented Jan 7, 2025

!sync

@modularbot modularbot added the imported-internally Signals that a given pull request has been imported internally. label Jan 7, 2025
@jackos
Copy link
Collaborator

jackos commented Jan 7, 2025

!sync

@modularbot
Copy link
Collaborator

✅🟣 This contribution has been merged 🟣✅

Your pull request has been merged to the internal upstream Mojo sources. It will be reflected here in the Mojo repository on the nightly branch during the next Mojo nightly release, typically within the next 24-48 hours.

We use Copybara to merge external contributions, click here to learn more.

@modularbot modularbot added the merged-internally Indicates that this pull request has been merged internally label Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
imported-internally Signals that a given pull request has been imported internally. merged-internally Indicates that this pull request has been merged internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants