Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Fix incorrect implicit type conversion output in variables.mdx documentation. #3907

Open
wants to merge 1 commit into
base: nightly
Choose a base branch
from
Open

[docs] Fix incorrect implicit type conversion output in variables.mdx documentation. #3907

wants to merge 1 commit into from

Conversation

el2e10
Copy link

@el2e10 el2e10 commented Dec 23, 2024

…ntation

  • The "Implicit type conversion" section shows the output of implicitly converting an Integer to Float64 as an Integer. It should have been a Float. Updated it to 1.0 instead of 1
  • Also added a print statement in that code snippet.

@el2e10
Fix incorrect implicit type conversion output in variables.mdx docume…
3d7d0b3 
…ntation

- The "Implicit type conversion" section shows the output of implicitly converting an Integer to Float64 as an Integer. It should have been a Float. Updated it to 1.0 instead of 1
- Also added a print statement in that code snippet.

Signed-off-by: Eldho Ittan George <7940237+el2e10@users.noreply.github.com>
@el2e10 el2e10 requested a review from a team as a code owner December 23, 2024 03:04
@el2e10 el2e10 changed the title Fix incorrect implicit type conversion output in variables.mdx documentation. [docs] Fix incorrect implicit type conversion output in variables.mdx documentation. Dec 23, 2024
arthurevans
arthurevans approved these changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@arthurevans arthurevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch--thanks!

@arthurevans
Copy link
Collaborator

!sync

@modularbot modularbot added the imported-internally Signals that a given pull request has been imported internally. label Jan 7, 2025
@modularbot
Copy link
Collaborator

✅🟣 This contribution has been merged 🟣✅

Your pull request has been merged to the internal upstream Mojo sources. It will be reflected here in the Mojo repository on the nightly branch during the next Mojo nightly release, typically within the next 24-48 hours.

We use Copybara to merge external contributions, click here to learn more.

@modularbot modularbot added the merged-internally Indicates that this pull request has been merged internally label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arthurevans arthurevans arthurevans approved these changes

Assignees

@arthurevans arthurevans

Labels
imported-internally Signals that a given pull request has been imported internally. merged-internally Indicates that this pull request has been merged internally
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@el2e10 @arthurevans @modularbot