Return an empty String instead of null when creating a mock #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe `String` values in mocks should return `""` by default. It is a historically 'special' type which has always had some special 'primitive-like' privileges. I assume people expect it to return a nice value as well!
|
Has this PR been reviewed yet? |
|
What does plain Mockito do? |
|
Plain Mockito returns |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #372 for reference
I believe
Stringvalues in mocks should return""by default.It is a historically 'special' type which has always had some special 'primitive-like' privileges.
I assume people expect it to return a nice value as well!
Thank you for submitting a pull request! But first: