Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation slight outdated (for quick setup) #494

Open
perrochon opened this issue Nov 22, 2018 · 7 comments
Open

Documentation slight outdated (for quick setup) #494

perrochon opened this issue Nov 22, 2018 · 7 comments

Comments

@perrochon
Copy link

Tried to get this running. Looks super nice and promising. A few things I noticed while setting it up.

  1. I needed to set min sdk to 26 (Oreo) to compile. Not a problem, and easily fixable through error messages

  2. Could it be that .defineZoomLevel replaced .defineDetail and .addDetailLevel? readme.md refers to defineDetail in the quick setup , and the wiki uses addDetailLevel. The demo code shows how.

@moagrius
Copy link
Owner

yeah the javadocs are completely outdated and i haven't gone through all the wiki pages. the demo and readme should be relatively correct, although feel free to fork and PR (or just edit the wiki directly) if you have the bandwidth to correct any typos or misnamed methods. otherwise i'll get to it when i can - i usually work in short bursts every few months.

yeah it's defineZoomLevel(int zoom, Object data) now. https://github.com/moagrius/TileView/blob/master/tileview/src/main/java/com/qozix/tileview/TileView.java

@perrochon
Copy link
Author

#496 for README.me
I haven't found a way to edit the Wiki or do a pull request on Wiki. It's one copy paste from the PR to the Wiki for the same line.

@moagrius
Copy link
Owner

you should be able to edit the wiki directly, but it's np i can do it - what page/line?

@Pavle37
Copy link

Pavle37 commented Dec 2, 2018

I also get an error message for min sdk to be 26. How can i fix this to use it with min sdk 19?

@moagrius
Copy link
Owner

moagrius commented Dec 2, 2018

This should be in a different issue thread, but nity demo and library have minSdk of 19. Check other Gradle or manifest settings in your project, or other dependencies

@tva-TIS
Copy link

tva-TIS commented Jul 19, 2019

Also in README.md TileView.Builder().build() does not return the build TileView anymore but void and takes the TileView to build as a paramter.

@moagrius
Copy link
Owner

i will fix this as soon as i get some time for this project (weeks away)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants