Skip to content

Commit

Permalink
Remove internal header inclusion guards
Browse files Browse the repository at this point in the history
Inclusion of internal headers is already both centralized and follows
strict rules.  Inclusion guards are both an unneccessary maintenance
burden and may hide inclusion order bugs.
  • Loading branch information
elmindreda committed May 25, 2017
1 parent bc7ebc1 commit 372e908
Showing 19 changed files with 0 additions and 82 deletions.
4 changes: 0 additions & 4 deletions src/cocoa_joystick.h
Original file line number Diff line number Diff line change
@@ -24,9 +24,6 @@
//
//========================================================================

#ifndef _glfw3_cocoa_joystick_h_
#define _glfw3_cocoa_joystick_h_

#include <IOKit/IOKitLib.h>
#include <IOKit/IOCFPlugIn.h>
#include <IOKit/hid/IOHIDLib.h>
@@ -50,4 +47,3 @@ typedef struct _GLFWjoystickNS
void _glfwInitJoysticksNS(void);
void _glfwTerminateJoysticksNS(void);

#endif // _glfw3_cocoa_joystick_h_
4 changes: 0 additions & 4 deletions src/cocoa_platform.h
Original file line number Diff line number Diff line change
@@ -24,9 +24,6 @@
//
//========================================================================

#ifndef _glfw3_cocoa_platform_h_
#define _glfw3_cocoa_platform_h_

#include <stdint.h>
#include <dlfcn.h>

@@ -164,4 +161,3 @@ void _glfwPollMonitorsNS(void);
GLFWbool _glfwSetVideoModeNS(_GLFWmonitor* monitor, const GLFWvidmode* desired);
void _glfwRestoreVideoModeNS(_GLFWmonitor* monitor);

#endif // _glfw3_cocoa_platform_h_
4 changes: 0 additions & 4 deletions src/egl_context.h
Original file line number Diff line number Diff line change
@@ -25,9 +25,6 @@
//
//========================================================================

#ifndef _glfw3_egl_context_h_
#define _glfw3_egl_context_h_

#if defined(_GLFW_USE_EGLPLATFORM_H)
#include <EGL/eglplatform.h>
#elif defined(_GLFW_WIN32)
@@ -219,4 +216,3 @@ GLFWbool _glfwChooseVisualEGL(const _GLFWctxconfig* ctxconfig,
Visual** visual, int* depth);
#endif /*_GLFW_X11*/

#endif // _glfw3_egl_context_h_
4 changes: 0 additions & 4 deletions src/glx_context.h
Original file line number Diff line number Diff line change
@@ -25,9 +25,6 @@
//
//========================================================================

#ifndef _glfw3_glx_context_h_
#define _glfw3_glx_context_h_

#define GLX_VENDOR 1
#define GLX_RGBA_BIT 0x00000001
#define GLX_WINDOW_BIT 0x00000001
@@ -180,4 +177,3 @@ GLFWbool _glfwChooseVisualGLX(const _GLFWctxconfig* ctxconfig,
const _GLFWfbconfig* fbconfig,
Visual** visual, int* depth);

#endif // _glfw3_glx_context_h_
5 changes: 0 additions & 5 deletions src/internal.h
Original file line number Diff line number Diff line change
@@ -25,10 +25,6 @@
//
//========================================================================

#ifndef _glfw3_internal_h_
#define _glfw3_internal_h_


#if defined(_GLFW_USE_CONFIG_H)
#include "glfw_config.h"
#endif
@@ -961,4 +957,3 @@ void _glfwTerminateVulkan(void);
*/
const char* _glfwGetVulkanResultString(VkResult result);

#endif // _glfw3_internal_h_
4 changes: 0 additions & 4 deletions src/linux_joystick.h
Original file line number Diff line number Diff line change
@@ -24,9 +24,6 @@
//
//========================================================================

#ifndef _glfw3_linux_joystick_h_
#define _glfw3_linux_joystick_h_

#include <regex.h>

#define _GLFW_PLATFORM_JOYSTICK_STATE _GLFWjoystickLinux linjs
@@ -55,4 +52,3 @@ GLFWbool _glfwInitJoysticksLinux(void);
void _glfwTerminateJoysticksLinux(void);
void _glfwDetectJoystickConnectionLinux(void);

#endif // _glfw3_linux_joystick_h_
4 changes: 0 additions & 4 deletions src/mir_platform.h
Original file line number Diff line number Diff line change
@@ -24,9 +24,6 @@
//
//========================================================================

#ifndef _glfw3_mir_platform_h_
#define _glfw3_mir_platform_h_

#include <sys/queue.h>
#include <pthread.h>
#include <dlfcn.h>
@@ -134,4 +131,3 @@ extern void _glfwPollMonitorsMir(void);
extern void _glfwInitEventQueueMir(EventQueue* queue);
extern void _glfwDeleteEventQueueMir(EventQueue* queue);

#endif // _glfw3_mir_platform_h_
4 changes: 0 additions & 4 deletions src/nsgl_context.h
Original file line number Diff line number Diff line change
@@ -24,9 +24,6 @@
//
//========================================================================

#ifndef _glfw3_nsgl_context_h_
#define _glfw3_nsgl_context_h_

#define _GLFW_PLATFORM_CONTEXT_STATE _GLFWcontextNSGL nsgl
#define _GLFW_PLATFORM_LIBRARY_CONTEXT_STATE _GLFWlibraryNSGL nsgl

@@ -57,4 +54,3 @@ GLFWbool _glfwCreateContextNSGL(_GLFWwindow* window,
const _GLFWfbconfig* fbconfig);
void _glfwDestroyContextNSGL(_GLFWwindow* window);

#endif // _glfw3_nsgl_context_h_
5 changes: 0 additions & 5 deletions src/null_joystick.h
Original file line number Diff line number Diff line change
@@ -24,11 +24,6 @@
//
//========================================================================

#ifndef _glfw3_null_joystick_h_
#define _glfw3_null_joystick_h_

#define _GLFW_PLATFORM_JOYSTICK_STATE int nulljs
#define _GLFW_PLATFORM_LIBRARY_JOYSTICK_STATE int nulljs


#endif // _glfw3_null_joystick_h_
5 changes: 0 additions & 5 deletions src/null_platform.h
Original file line number Diff line number Diff line change
@@ -25,9 +25,6 @@
//
//========================================================================

#ifndef _glfw3_null_platform_h_
#define _glfw3_null_platform_h_

#include <dlfcn.h>

#define _GLFW_PLATFORM_WINDOW_STATE _GLFWwindowNull null
@@ -63,5 +60,3 @@ typedef struct _GLFWwindowNull
int height;
} _GLFWwindowNull;


#endif // _glfw3_null_platform_h_
4 changes: 0 additions & 4 deletions src/osmesa_context.h
Original file line number Diff line number Diff line change
@@ -25,9 +25,6 @@
//
//========================================================================

#ifndef _glfw3_osmesa_context_h_
#define _glfw3_osmesa_context_h_

#define OSMESA_RGBA 0x1908
#define OSMESA_FORMAT 0x22
#define OSMESA_DEPTH_BITS 0x30
@@ -95,4 +92,3 @@ GLFWbool _glfwCreateContextOSMesa(_GLFWwindow* window,
const _GLFWctxconfig* ctxconfig,
const _GLFWfbconfig* fbconfig);

#endif // _glfw3_osmesa_context_h_
4 changes: 0 additions & 4 deletions src/posix_time.h
Original file line number Diff line number Diff line change
@@ -25,9 +25,6 @@
//
//========================================================================

#ifndef _glfw3_posix_time_h_
#define _glfw3_posix_time_h_

#define _GLFW_PLATFORM_LIBRARY_TIMER_STATE _GLFWtimerPOSIX posix

#include <stdint.h>
@@ -45,4 +42,3 @@ typedef struct _GLFWtimerPOSIX

void _glfwInitTimerPOSIX(void);

#endif // _glfw3_posix_time_h_
5 changes: 0 additions & 5 deletions src/posix_tls.h
Original file line number Diff line number Diff line change
@@ -25,9 +25,6 @@
//
//========================================================================

#ifndef _glfw3_posix_tls_h_
#define _glfw3_posix_tls_h_

#include <pthread.h>

#define _GLFW_PLATFORM_TLS_STATE _GLFWtlsPOSIX posix
@@ -42,5 +39,3 @@ typedef struct _GLFWtlsPOSIX

} _GLFWtlsPOSIX;


#endif // _glfw3_posix_tls_h_
5 changes: 0 additions & 5 deletions src/wgl_context.h
Original file line number Diff line number Diff line change
@@ -25,10 +25,6 @@
//
//========================================================================

#ifndef _glfw3_wgl_context_h_
#define _glfw3_wgl_context_h_


#define WGL_NUMBER_PIXEL_FORMATS_ARB 0x2000
#define WGL_SUPPORT_OPENGL_ARB 0x2010
#define WGL_DRAW_TO_WINDOW_ARB 0x2001
@@ -157,4 +153,3 @@ GLFWbool _glfwCreateContextWGL(_GLFWwindow* window,
const _GLFWctxconfig* ctxconfig,
const _GLFWfbconfig* fbconfig);

#endif // _glfw3_wgl_context_h_
4 changes: 0 additions & 4 deletions src/win32_joystick.h
Original file line number Diff line number Diff line change
@@ -24,9 +24,6 @@
//
//========================================================================

#ifndef _glfw3_win32_joystick_h_
#define _glfw3_win32_joystick_h_

#define _GLFW_PLATFORM_JOYSTICK_STATE _GLFWjoystickWin32 win32
#define _GLFW_PLATFORM_LIBRARY_JOYSTICK_STATE int dummy

@@ -56,4 +53,3 @@ void _glfwTerminateJoysticksWin32(void);
void _glfwDetectJoystickConnectionWin32(void);
void _glfwDetectJoystickDisconnectionWin32(void);

#endif // _glfw3_win32_joystick_h_
4 changes: 0 additions & 4 deletions src/win32_platform.h
Original file line number Diff line number Diff line change
@@ -25,9 +25,6 @@
//
//========================================================================

#ifndef _glfw3_win32_platform_h_
#define _glfw3_win32_platform_h_

// We don't need all the fancy stuff
#ifndef NOMINMAX
#define NOMINMAX
@@ -351,4 +348,3 @@ void _glfwPollMonitorsWin32(void);
GLFWbool _glfwSetVideoModeWin32(_GLFWmonitor* monitor, const GLFWvidmode* desired);
void _glfwRestoreVideoModeWin32(_GLFWmonitor* monitor);

#endif // _glfw3_win32_platform_h_
4 changes: 0 additions & 4 deletions src/wl_platform.h
Original file line number Diff line number Diff line change
@@ -24,9 +24,6 @@
//
//========================================================================

#ifndef _glfw3_wayland_platform_h_
#define _glfw3_wayland_platform_h_

#include <wayland-client.h>
#include <xkbcommon/xkbcommon.h>
#include <xkbcommon/xkbcommon-compose.h>
@@ -169,4 +166,3 @@ typedef struct _GLFWcursorWayland

void _glfwAddOutputWayland(uint32_t name, uint32_t version);

#endif // _glfw3_wayland_platform_h_
4 changes: 0 additions & 4 deletions src/x11_platform.h
Original file line number Diff line number Diff line change
@@ -25,9 +25,6 @@
//
//========================================================================

#ifndef _glfw3_x11_platform_h_
#define _glfw3_x11_platform_h_

#include <unistd.h>
#include <signal.h>
#include <stdint.h>
@@ -335,4 +332,3 @@ void _glfwInputErrorX11(int error, const char* message);

void _glfwPushSelectionToManagerX11(void);

#endif // _glfw3_x11_platform_h_
5 changes: 0 additions & 5 deletions src/xkb_unicode.h
Original file line number Diff line number Diff line change
@@ -24,10 +24,5 @@
//
//========================================================================

#ifndef _glfw3_xkb_unicode_h_
#define _glfw3_xkb_unicode_h_


long _glfwKeySym2Unicode(unsigned int keysym);

#endif // _glfw3_xkb_unicode_h_

0 comments on commit 372e908

Please sign in to comment.