Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target make safetest got broken #273

Merged
merged 4 commits into from
Dec 21, 2024
Merged

Target make safetest got broken #273

merged 4 commits into from
Dec 21, 2024

Conversation

mindflayer
Copy link
Owner

@mindflayer mindflayer commented Nov 25, 2024

It used to be possible to only run the tests relying on Mocket - non-real socket ones - but it looks like something changed in the Redis client that is worth investigating (something more needs to be mocked).

It helps to overcome issues like the one mentioned in #272

See https://redis.io/docs/latest/commands/client-setinfo/

@mindflayer mindflayer force-pushed the make-safetest-got-broken branch from 54fe299 to f154fba Compare November 25, 2024 15:28
@mindflayer mindflayer force-pushed the make-safetest-got-broken branch from f154fba to 5405e2e Compare November 25, 2024 15:28
@coveralls
Copy link

Coverage Status

coverage: 98.808% (-0.2%) from 99.025%
when pulling 5405e2e on make-safetest-got-broken
into a5b5e34 on main.

@coveralls
Copy link

coveralls commented Nov 25, 2024

Coverage Status

coverage: 98.68%. remained the same
when pulling 99a1b99 on make-safetest-got-broken
into 9cfad4c on main.

@mindflayer mindflayer merged commit 895e299 into main Dec 21, 2024
10 checks passed
@mindflayer mindflayer deleted the make-safetest-got-broken branch December 21, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants