Add very basic tokenizer for command line #239344
Merged
+97
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meganrogge
reviewed
Jan 31, 2025
| if (spaceIndex === -1) { | ||
| return TokenType.Command; | ||
| } | ||
| const tokenIndex = spaceIndex === -1 ? 0 : spaceIndex + 1; |
There was a problem hiding this comment.
bc we return when spaceIndex === -1 above this, I think we can just set this to spaceIndex + 1?
meganrogge
reviewed
Jan 31, 2025
| if (spaceIndex === -1) { | ||
| return TokenType.Command; | ||
| } | ||
| const tokenIndex = spaceIndex === -1 ? 0 : spaceIndex + 1; |
There was a problem hiding this comment.
Suggested change
| const tokenIndex = spaceIndex === -1 ? 0 : spaceIndex + 1; | |
| const tokenIndex = spaceIndex + 1; |
meganrogge
reviewed
Jan 31, 2025
| return TokenType.Command; | ||
| } | ||
| const tokenIndex = spaceIndex === -1 ? 0 : spaceIndex + 1; | ||
| const previousTokens = ctx.commandLine.substring(0, tokenIndex).trim(); |
There was a problem hiding this comment.
rename priorCommandFragment?
There was a problem hiding this comment.
Was trying to lean into the "token" wording here since chances are as we improve this we'll turn closer and closer into a real lexer and understand more of the tokens.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #239018
Issue example: