Skip to content

Commit

Permalink
removed small semantic mistakes
Browse files Browse the repository at this point in the history
  • Loading branch information
mringler committed Mar 12, 2021
1 parent bc66b6c commit 2c52635
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 24 deletions.
10 changes: 0 additions & 10 deletions phpstan-baseline.neon

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions src/Propel/Runtime/ActiveQuery/BaseModelCriteria.php
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,7 @@ class BaseModelCriteria extends Criteria implements IteratorAggregate
*/
public function __construct($dbName = null, $modelName = null, $modelAlias = null)
{
$this->setDbName($dbName);
$this->originalDbName = $dbName;
parent::__construct($dbName);
$this->setModelName($modelName);
$this->modelAlias = $modelAlias;
}
Expand Down
12 changes: 12 additions & 0 deletions src/Propel/Runtime/ActiveQuery/Criteria.php
Original file line number Diff line number Diff line change
Expand Up @@ -277,6 +277,18 @@ class Criteria
*/
public $replacedColumns = [];

/**
* temporary property used in replaceNames
*
* @var string|null
*/
protected $currentAlias;

/**
* @var bool
*/
protected $foundMatch = false;

/**
* Creates a new instance with the default capacity which corresponds to
* the specified database.
Expand Down
12 changes: 0 additions & 12 deletions src/Propel/Runtime/ActiveQuery/ModelCriteria.php
Original file line number Diff line number Diff line change
Expand Up @@ -92,18 +92,6 @@ class ModelCriteria extends BaseModelCriteria
*/
protected $select;

/**
* temporary property used in replaceNames
*
* @var string|null
*/
protected $currentAlias;

/**
* @var bool
*/
protected $foundMatch = false;

/**
* Used to memorize whether we added self-select columns before.
*
Expand Down

0 comments on commit 2c52635

Please sign in to comment.