Allow no array

mfrosi · Jul 10, 2024 · e1b9cd0 · e1b9cd0
1 parent e5beb92
commit e1b9cd0
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 5 deletions.
diff --git a/rair-node/bin/api/notifications/notifications.Controller.js b/rair-node/bin/api/notifications/notifications.Controller.js
@@ -1,6 +1,11 @@
 const express = require('express');
 const { requireUserSession, validation } = require('../../middleware');
-const { markNotificationAsRead, getSingleNotification, listNotifications, deleteNotification } = require('./notifications.Service');
+const {
+    markNotificationAsRead,
+    getSingleNotification,
+    listNotifications,
+    deleteNotification,
+} = require('./notifications.Service');
 
 const router = express.Router();
 

diff --git a/rair-node/bin/api/notifications/notifications.Service.js b/rair-node/bin/api/notifications/notifications.Service.js
@@ -93,10 +93,18 @@ module.exports = {
     },
     markNotificationAsRead: async (req, res, next) => {
         try {
+            const { publicAddress } = req.user;
             const { ids } = req.body;
-            const result = await Notification.updateMany({
-                _id: { $in: ids },
-            }, { $set: { read: true } });
+            const filter = {
+                user: publicAddress,
+            };
+            if (ids.length) {
+                filter._id = { $in: ids };
+            }
+            const result = await Notification.updateMany(
+                filter,
+                { $set: { read: true } },
+            );
             return res.json({
                 success: true,
                 updated: result.modifiedCount,
@@ -108,8 +116,15 @@ module.exports = {
     },
     deleteNotification: async (req, res, next) => {
         try {
+            const { publicAddress } = req.user;
             const { ids } = req.body;
-            const result = await Notification.deleteMany({ _id: { $in: ids } });
+            const filter = {
+                user: publicAddress,
+            };
+            if (ids.length) {
+                filter._id = { $in: ids };
+            }
+            const result = await Notification.deleteMany(filter);
             return res.json({
                 success: true,
                 deleted: result.deletedCount,