Make getgroups(2) actually work

Fixes ish-app#660
mehfooz09 · Apr 12, 2020 · 806d1f1 · 806d1f1
1 parent 4c18647
commit 806d1f1
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/kernel/getset.c b/kernel/getset.c
@@ -143,20 +143,26 @@ int_t sys_getresgid(addr_t rgid_addr, addr_t egid_addr, addr_t sgid_addr) {
 }
 
 int_t sys_getgroups(dword_t size, addr_t list) {
+    STRACE("getgroups(%d, %#x)", size, list);
     if (size == 0)
         return current->ngroups;
     if (size < current->ngroups)
         return _EINVAL;
+    for (unsigned i = 0; i < current->ngroups; i++)
+        STRACE(" %d", current->groups[i]);
     if (user_write(list, current->groups, size * sizeof(uid_t_)))
         return _EFAULT;
-    return 0;
+    return current->ngroups;
 }
 
 int_t sys_setgroups(dword_t size, addr_t list) {
+    STRACE("setgroups(%d, %#x)", size, list);
     if (size > MAX_GROUPS)
         return _EINVAL;
     if (user_read(list, current->groups, size * sizeof(uid_t_)))
         return _EFAULT;
+    for (unsigned i = 0; i < size; i++)
+        STRACE(" %d", current->groups[i]);
     current->ngroups = size;
     return 0;
 }