Allow a user to make sticky blog posts #16736
Conversation
|
i like it. could it be confusing mixing sticky ones into the recency list without any visual clarification tho? |
I agree, I went for something very simple (the green border) that was already available to me. Note that, in my opinion, the visual clarification is mainly for the author of the post. I don't think the users visiting the profile will care about it: they will see the posts in the order the author decided. |
|
I suggest to use a star positioned where the author's link is (as the author link is not shown on the posts when you look at their profile). The star + the green border should make the sticky post stand out
|
|
it looks like github removed the :lgtm: jesus emoji. 😭 |
ui/bits/css/ublog/_card.scss
Outdated
| @@ -20,6 +20,12 @@ | |||
| 0 0 20px $c-link; | |||
| } | |||
|
|
|||
| &--sticky { | |||
There was a problem hiding this comment.
i know it's everywhere in our code, but using parent selector to glue names is bad for searchability, which means it is just bad.
There was a problem hiding this comment.
that's just an opinion, i'm not suggesting you rewrite all of our scss here! 😄
There was a problem hiding this comment.
Yeap, I just copied the &--link above
I think I'll leave it like that for the time being.
Is there a discussion somewhere about the best practices to adopt when working with scss ?
I don't see why we needed it? Sorting also works with the missing field
unless I'm missing something?
This is a proposition for issue #15995 where changes are minimum
Toggle 'Sticky post' in your blog post
And your post will appear first in your profile
and in your coach page (if you are a coach)