Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dataset search-input compostion can't work in chrome #11907

Merged
merged 2 commits into from
Dec 21, 2024

Conversation

xhdd123321
Copy link
Contributor

Summary

The search box on the dataset page has two bugs when using Chinese input in chrome browser.

  1. "isComposing" prevents characters from being rendered and makes the input method not work properly.(first gif below)
  2. The onChange event of the input component triggers before the onCompositionEnd event in chrome, causing the search api not to be triggered after the IME confirms the input.(second gif below)

I added an internal value to make sure the input box renders the character being typed in IME properly to fix the first bug, and called the onchange event trigger at the end of onCompositionEnd to fix bug 2

Screenshots

I've added console log logging to keep track of variables when debugging locally
console_log

Before After(fix bug1) After(fix bug1+bug2)
nofix fixed1 fixed2

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. ☕️ typescript Pull request that update TypeScript code. 🐞 bug Something isn't working labels Dec 20, 2024
@crazywoola crazywoola requested a review from zxhlyh December 20, 2024 13:37
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 21, 2024
@crazywoola crazywoola merged commit 6ded06c into langgenius:main Dec 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files. ☕️ typescript Pull request that update TypeScript code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants