Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(llm_node): support order in text and files #11837

Merged
merged 5 commits into from
Dec 20, 2024
Merged

feat(llm_node): support order in text and files #11837

merged 5 commits into from
Dec 20, 2024

Conversation

laipz8200
Copy link
Member

Summary

tested on GPT-4o, Claude 3.5 sonnet, and Gemini 2.0.

GPT-4o doesn't support this feature but can work normally.

will close #11641

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Screenshots

Before After
... image

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@laipz8200
feat(llm_node): support order in text and files
fa132fb 
Signed-off-by: -LAN- <laipz8200@outlook.com>
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. 💪 enhancement New feature or request labels Dec 19, 2024
@laipz8200
test(*): Fix File init
1abfc9b 
Signed-off-by: -LAN- <laipz8200@outlook.com>
crazywoola
crazywoola previously approved these changes Dec 19, 2024
View reviewed changes
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 19, 2024
@laipz8200
fix: remove Field from parameters
fe2ffbf 
Signed-off-by: -LAN- <laipz8200@outlook.com>
@laipz8200
test: fix File init
0483229 
Signed-off-by: -LAN- <laipz8200@outlook.com>
@laipz8200 laipz8200 self-assigned this Dec 19, 2024
@laipz8200 laipz8200 marked this pull request as draft December 19, 2024 10:15
@laipz8200
feat(models): make sure Conversation.inputs and Message.inputs can be…
c20146f 
… converted correctly

Signed-off-by: -LAN- <laipz8200@outlook.com>
@laipz8200 laipz8200 marked this pull request as ready for review December 20, 2024 04:29
@laipz8200 laipz8200 requested a review from crazywoola December 20, 2024 04:30
@crazywoola crazywoola merged commit 996a913 into main Dec 20, 2024
8 checks passed
@crazywoola crazywoola deleted the feat/support-file-order-in-llm-prompt branch December 20, 2024 06:12
jiangbo721 pushed a commit to jiangbo721/dify that referenced this pull request Dec 20, 2024
@laipz8200
feat(llm_node): support order in text and files (langgenius#11837)
980aecf 
Signed-off-by: -LAN- <laipz8200@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazywoola crazywoola crazywoola approved these changes

Assignees

@laipz8200 laipz8200

Labels
💪 enhancement New feature or request lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Maintain the Order of Text and Files in Prompt for Multimodal Models
2 participants
@laipz8200 @crazywoola