Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to add route via proxy when using Lagoon integration #6

Open
tobybellwood opened this issue Mar 1, 2021 · 5 comments
Open
Assignees

Comments

@tobybellwood
Copy link
Collaborator

When using the Lando Lagoon integration, we should be able to add a custom route (either lndo.site or custom DNS) as per https://docs.lando.dev/guides/lando-101/lando-proxy.html

However, when trying this, even with a vanilla project (such as https://github.com/amazeeio/drupal-example-simple) the custom routes defined in the .lando.yml are not usable - but the default routes (eg mailhog) are.

name: drupal8-example-simple
recipe: lagoon
config:
  flavor: drupal
  build:
    - composer install
proxy:
  nginx:
    - abcde.lndo.site

image

I have tested alongside this with a default (non-lagoon) Lando project and it all works as expected as per documentation.

@pirog pirog self-assigned this Mar 2, 2021
@pirog
Copy link
Member

pirog commented Mar 2, 2021

@tobybellwood thanks for the report. Let me see if i can replicate.

@pirog
Copy link
Member

pirog commented Mar 2, 2021

Running against latest Lando 3.0.26, steps to replicate:

  1. git clone --branch 8.x https://github.com/amazeeio/drupal-example-simple.git amazee-d8-example

  2. cd amazee-d8-example

  3. lando start

  4. Above seems to work as expected. Now, replace the .lando.yml with:

name: drupal8-example-simple
recipe: lagoon
config:
  flavor: drupal
  build:
    - composer install
proxy:
  nginx:
    - abcde.lndo.site
  1. lando rebuild

Screen Shot 2021-03-02 at 8 26 04 AM

A key difference for me here is that i am getting a 502 Bad Gateway and not a 404 which is what @tobybellwood said he had.

@pirog
Copy link
Member

pirog commented Mar 2, 2021

@tobybellwood, try this

name: drupal8-example-simple
recipe: lagoon
config:
  flavor: drupal
  build:
    - composer install
proxy:
  nginx:
    - abcde.lndo.site:8080

The lagoon nginx service runs on port 8080 by default so you need the extra :8080. If you omit it defaults to :80 which is what the lando nginx service uses. We might just want to document this somewhere.

@tobybellwood
Copy link
Collaborator Author

ah, perfect - can confirm that works correctly. I'll throw a PR into the docs to help people out.

@stale
Copy link

stale bot commented Oct 2, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions and please check out this if you are wondering why we auto close issues.

@rtfm-47 rtfm-47 transferred this issue from lando/lando Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants