Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lagoon integration does not work with custom domains #20

Open
serhat-ozkara opened this issue Jan 17, 2022 · 4 comments
Open

Lagoon integration does not work with custom domains #20

serhat-ozkara opened this issue Jan 17, 2022 · 4 comments
Labels
Feature Feature Request Lando 4 To be done in Lando 4

Comments

@serhat-ozkara
Copy link

this.apiURL = `https://api.${this.host}`;

@serhat-ozkara
Copy link
Author

This assumes all Lagoon instances are using api.(domain) and ssh.(domain) but one can use whatever domain for said lagoon services

@labboy0276
Copy link
Contributor

@serhat-ozkara can you specify more about your use case, what urls you are trying to use and why. This will us get a better picture of what is going on.

@serhat-ozkara
Copy link
Author

Hello @labboy0276,

When using custom lagoon environments, lagoon does not necessarily have to use ssh.mydomain.com or api.mydomain.com subdomains.
One can use my-own-sobdomain.mydomain.com for SSH address and my-other-subdomain.mydomain.com for API endpoint.

But on api.js file, it is assumed that lagoon SSH is hosted on SSH.mydomain.com and API endpoint on api.mydomain.com.

So, sharing the domain on ${this.host} for SSH and API endpoints for Lagoon integration, incorrectly assumes this approach.
Users should be able to set their own addresses and domains for SSH and API endpoint addresses and ports.

Hardcoding subdomains like this: https://api.${this.host}; or ssh.${this.host}; limits the usability.

Thanks,

@labboy0276
Copy link
Contributor

@serhat-ozkara ok this is something we can do in the future. Most likely in Lando 4.

@labboy0276 labboy0276 added Feature Feature Request Lando 4 To be done in Lando 4 labels Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature Request Lando 4 To be done in Lando 4
Projects
None yet
Development

No branches or pull requests

2 participants