Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add docs to connection's poll #2

Merged
merged 7 commits into from
Aug 9, 2024

Conversation

pratik151192
Copy link
Contributor

@pratik151192 pratik151192 commented Aug 8, 2024

Adding comments, README, and diagrams to protosocket-connection crate

@pratik151192 pratik151192 marked this pull request as ready for review August 8, 2024 22:01
Copy link
Owner

@kvc0 kvc0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pr! I've got some comments on the comments!

protosocket-connection/README.md Outdated Show resolved Hide resolved
protosocket-connection/README.md Outdated Show resolved Hide resolved
protosocket-connection/README.md Outdated Show resolved Hide resolved
protosocket-connection/README.md Outdated Show resolved Hide resolved
protosocket-connection/README.md Show resolved Hide resolved
protosocket-connection/src/connection.rs Outdated Show resolved Hide resolved
protosocket-connection/src/connection.rs Outdated Show resolved Hide resolved
protosocket-connection/src/connection.rs Outdated Show resolved Hide resolved
protosocket-connection/src/connection.rs Outdated Show resolved Hide resolved
protosocket-connection/src/connection.rs Outdated Show resolved Hide resolved
@pratik151192 pratik151192 requested a review from kvc0 August 9, 2024 19:20
Copy link
Owner

@kvc0 kvc0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one more character and we'll be in good shape

Comment on lines +13 to +16
The `poll()` function on `connection.rs` controls the lifecycle of the entire connection. You're recommended to read individual comments on the code to understand the flow, but below is a sequence diagram to get you started:

```mermaid
sequenceDiagram
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty nice

protosocket-connection/src/connection.rs Outdated Show resolved Hide resolved
Co-authored-by: kvc0 <3454741+kvc0@users.noreply.github.com>
@pratik151192 pratik151192 requested a review from kvc0 August 9, 2024 19:37
Copy link
Owner

@kvc0 kvc0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@kvc0 kvc0 merged commit d934a63 into kvc0:main Aug 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants