Make kube-proxy ipset parameters 'hashSize' 'maxElem' customizable #129390

weak-fox · 2024-12-25T04:14:21Z

What type of PR is this?

/kind feature
/kind api-change

What this PR does / why we need it:

This PR allows IPSet hashSize, maxElem to be configurable via kube-proxy flags/config.
The following flags are being added:

      --ipvs-ipset-hashsize int32
      --ipvs-ipset-maxelements int32

The default value comes from the previous code:

kubernetes/pkg/proxy/ipvs/ipset/ipset.go

Lines 130 to 149 in 35f5841

    
           func (set *IPSet) setIPSetDefaults() { 
        
           	// Setting default values if not present 
        
           	if set.HashSize == 0 { 
        
           		set.HashSize = 1024 
        
           	} 
        
           	if set.MaxElem == 0 { 
        
           		set.MaxElem = 65536 
        
           	} 
        
           	// Default protocol is IPv4 
        
           	if set.HashFamily == "" { 
        
           		set.HashFamily = ProtocolFamilyIPV4 
        
           	} 
        
           	// Default ipset type is "hash:ip,port" 
        
           	if len(set.SetType) == 0 { 
        
           		set.SetType = HashIPPort 
        
           	} 
        
           	if len(set.PortRange) == 0 { 
        
           		set.PortRange = DefaultPortRange 
        
           	} 
        
           }

Which issue(s) this PR fixes:

Fixes #129389

Special notes for your reviewer:

The PR introduces new API fields in the v1alpha1 API group for kube-proxy configuration. The changes are backward compatible as default values are provided.

Does this PR introduce a user-facing change?

add kube-proxy flags --ipvs-ipset-hashsize --ipvs-ipset-maxelements to configure IPSet.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

linux-foundation-easycla · 2024-12-25T04:14:27Z

The committers listed above are authorized under a signed CLA.

✅ login: weak-fox (ee26aa2, 77ab439, d98c544)

k8s-ci-robot · 2024-12-25T04:14:29Z

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot · 2024-12-25T04:14:30Z

Welcome @weak-fox!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2024-12-25T04:14:30Z

Hi @weak-fox. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-triage-robot · 2024-12-25T04:29:55Z

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

aroradaman · 2024-12-25T09:44:14Z

/ok-to-test

aroradaman · 2024-12-25T09:45:40Z

/cc @uablrek

pkg/proxy/apis/config/validation/validation_test.go

pkg/proxy/apis/config/types.go

k8s-ci-robot · 2024-12-26T07:34:49Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: weak-fox
Once this PR has been reviewed and has the lgtm label, please assign thockin for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

cmd/kube-proxy/OWNERS
pkg/generated/openapi/OWNERS
pkg/proxy/apis/config/OWNERS
pkg/proxy/ipvs/OWNERS
staging/src/k8s.io/kube-proxy/config/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1. Change `MaxElem` to `MaxElements` 2. Change `IPVSIPSetConfiguration` to `KubeProxyIPSetConfiguration`; 3. Resolved inconsistent variable names in comments

weak-fox · 2024-12-26T08:28:42Z

/retest-required

Make kube-proxy ipset parameters 'hashSize' 'maxElem' customizable

ee26aa2

k8s-ci-robot added the do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Dec 25, 2024

k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 25, 2024

k8s-ci-robot requested review from andrewsykim and caesarxuchao December 25, 2024 04:14

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 25, 2024

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 25, 2024

k8s-ci-robot requested a review from uablrek December 25, 2024 09:45

aroradaman reviewed Dec 25, 2024

View reviewed changes

pkg/proxy/apis/config/validation/validation_test.go Outdated Show resolved Hide resolved

pkg/proxy/apis/config/types.go Outdated Show resolved Hide resolved

pkg/proxy/apis/config/types.go Outdated Show resolved Hide resolved

pkg/proxy/apis/config/types.go Outdated Show resolved Hide resolved

weak-fox marked this pull request as draft December 26, 2024 08:05

weak-fox added 2 commits December 26, 2024 16:15

Update parameter and struct names

77ab439

1. Change `MaxElem` to `MaxElements` 2. Change `IPVSIPSetConfiguration` to `KubeProxyIPSetConfiguration`; 3. Resolved inconsistent variable names in comments

Add the test expectations

d98c544

weak-fox force-pushed the make_ipset_param_customizable branch from f2a1b40 to d98c544 Compare December 26, 2024 08:15

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. labels Dec 26, 2024

weak-fox marked this pull request as ready for review December 26, 2024 09:44

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 26, 2024

k8s-ci-robot requested review from bowei and caseydavenport December 26, 2024 09:44

weak-fox requested a review from aroradaman December 26, 2024 09:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make kube-proxy ipset parameters 'hashSize' 'maxElem' customizable #129390

Make kube-proxy ipset parameters 'hashSize' 'maxElem' customizable #129390

weak-fox commented Dec 25, 2024 •

edited

Loading

linux-foundation-easycla bot commented Dec 25, 2024 •

edited

Loading

k8s-ci-robot commented Dec 25, 2024

k8s-ci-robot commented Dec 25, 2024

k8s-ci-robot commented Dec 25, 2024

k8s-triage-robot commented Dec 25, 2024

aroradaman commented Dec 25, 2024

aroradaman commented Dec 25, 2024

k8s-ci-robot commented Dec 26, 2024

weak-fox commented Dec 26, 2024

	func (set *IPSet) setIPSetDefaults() {
	// Setting default values if not present
	if set.HashSize == 0 {
	set.HashSize = 1024
	}
	if set.MaxElem == 0 {
	set.MaxElem = 65536
	}
	// Default protocol is IPv4
	if set.HashFamily == "" {
	set.HashFamily = ProtocolFamilyIPV4
	}
	// Default ipset type is "hash:ip,port"
	if len(set.SetType) == 0 {
	set.SetType = HashIPPort
	}
	if len(set.PortRange) == 0 {
	set.PortRange = DefaultPortRange
	}
	}

Make kube-proxy ipset parameters 'hashSize' 'maxElem' customizable #129390

Are you sure you want to change the base?

Make kube-proxy ipset parameters 'hashSize' 'maxElem' customizable #129390

Conversation

weak-fox commented Dec 25, 2024 • edited Loading

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

linux-foundation-easycla bot commented Dec 25, 2024 • edited Loading

k8s-ci-robot commented Dec 25, 2024

k8s-ci-robot commented Dec 25, 2024

k8s-ci-robot commented Dec 25, 2024

k8s-triage-robot commented Dec 25, 2024

aroradaman commented Dec 25, 2024

aroradaman commented Dec 25, 2024

k8s-ci-robot commented Dec 26, 2024

weak-fox commented Dec 26, 2024

weak-fox commented Dec 25, 2024 •

edited

Loading

linux-foundation-easycla bot commented Dec 25, 2024 •

edited

Loading