Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wait until pod status reason is not empty for eviction pod status check #127997

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

wait until pod status reason is not empty for eviction pod status check #127997

wants to merge 1 commit into from
+12 −0

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented Oct 11, 2024

What type of PR is this?

/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

xref #127996

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/flake Categorizes issue or PR as related to a flaky test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 11, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Oct 11, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pacoxu
Once this PR has been reviewed and has the lgtm label, please assign tallclair for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/test sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 11, 2024
@pacoxu
Copy link
Member Author

pacoxu commented Oct 11, 2024

/test pull-crio-cgroupv1-node-e2e-eviction
/test pull-crio-cgroupv2-node-e2e-eviction

@pacoxu
Copy link
Member Author

pacoxu commented Oct 11, 2024

/test pull-crio-cgroupv1-node-e2e-eviction
/test pull-crio-cgroupv2-node-e2e-eviction

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 12, 2024
@pacoxu
Copy link
Member Author

pacoxu commented Oct 12, 2024

/test pull-crio-cgroupv1-node-e2e-eviction
/test pull-crio-cgroupv2-node-e2e-eviction

1 similar comment
@pacoxu
Copy link
Member Author

pacoxu commented Oct 12, 2024

/test pull-crio-cgroupv1-node-e2e-eviction
/test pull-crio-cgroupv2-node-e2e-eviction

@pacoxu pacoxu marked this pull request as ready for review December 24, 2024 06:34
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 24, 2024
@pacoxu
Copy link
Member Author

pacoxu commented Dec 24, 2024

/cc @sohankunkerkar @kwilczynski
/assign @haircommander
/test pull-crio-cgroupv1-node-e2e-eviction
/test pull-crio-cgroupv2-node-e2e-eviction

@k8s-ci-robot
Copy link
Contributor

@pacoxu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-linter-hints 3ec1f3d link false /test pull-kubernetes-linter-hints
pull-crio-cgroupv2-node-e2e-eviction 3ec1f3d link false /test pull-crio-cgroupv2-node-e2e-eviction

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@pacoxu
Copy link
Member Author

pacoxu commented Dec 24, 2024

/test pull-crio-cgroupv1-node-e2e-eviction
/test pull-crio-cgroupv2-node-e2e-eviction

The last run failed

{ failed [FAILED] priority 1 pod: fork-bomb-container-with-high-priority-pod failed before priority 2 pod: fork-bomb-container-with-low-priority-pod
Expected
    <v1.PodPhase>: Failed
not to equal
    <v1.PodPhase>: Failed
In [It] at: k8s.io/kubernetes/test/e2e_node/eviction_test.go:752 @ 12/24/24 08:23:44.081
}

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 24, 2024
@pacoxu pacoxu marked this pull request as draft December 24, 2024 09:33
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobbypage bobbypage Awaiting requested review from bobbypage

@kannon92 kannon92 Awaiting requested review from kannon92

@endocrimes endocrimes Awaiting requested review from endocrimes

@SergeyKanzhelev SergeyKanzhelev Awaiting requested review from SergeyKanzhelev

@kwilczynski kwilczynski Awaiting requested review from kwilczynski

@sohankunkerkar sohankunkerkar Awaiting requested review from sohankunkerkar

Assignees

@haircommander haircommander

Labels
area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/flake Categorizes issue or PR as related to a flaky test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
SIG Node CI/Test Board
Status: PRs Waiting on Author
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pacoxu @k8s-ci-robot @haircommander