Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Compatibility Version]Improve hack/verify-featuregates.sh script #129312

Open
siyuanfoundation opened this issue Dec 19, 2024 · 4 comments
Open

[Compatibility Version]Improve hack/verify-featuregates.sh script #129312

siyuanfoundation opened this issue Dec 19, 2024 · 4 comments
Assignees
@yongruilin
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@siyuanfoundation
Copy link
Contributor

siyuanfoundation commented Dec 19, 2024 •
edited
Loading

What would you like to be added?

Improve the code in https://github.com/kubernetes/kubernetes/tree/master/test/featuregates_linter

  1. since all the feature gates have been migrated to the versioned feature gate, we can remove the code to check no new feature is added to the unversioned feature gate.
  2. we need to add checks to verify that a feature can only be removed after been locked for at least 3 releases.
    • We support EmulationVersion up to N-3. So if a feature is locked starting N, the feature gate could still be set in BinaryVersion=N+1, EmulationVersion=N-1,-2, and BinaryVersion=N+2, EmulationVersion=N-1. So the feature gate can only be removed starting the BinaryVersion=N+3
  3. rename the go script to something more appropriate like featuregate-tracker rather than linter because it is not really a linter.

Why is this needed?

To improve code health and developer experience wrt Compatibility Version.
@siyuanfoundation siyuanfoundation added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 19, 2024
@k8s-ci-robot
Copy link
Contributor

There are no sig labels on this issue. Please add an appropriate label by using one of the following commands:

  • /sig <group-name>
  • /wg <group-name>
  • /committee <group-name>

Please see the group list for a listing of the SIGs, working groups, and committees available.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Dec 19, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Dec 19, 2024
@siyuanfoundation
Copy link
Contributor Author

/cc @yongruilin

@yongruilin
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yongruilin yongruilin

Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@siyuanfoundation @k8s-ci-robot @yongruilin