Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Container name not showed in the probe event message #129299

Open
astraw99 opened this issue Dec 19, 2024 · 1 comment · May be fixed by #129300
Open

Container name not showed in the probe event message #129299

astraw99 opened this issue Dec 19, 2024 · 1 comment · May be fixed by #129300
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/cli Categorizes an issue or PR as relevant to SIG CLI. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@astraw99
Copy link
Member

What would you like to be added?

Add container name Container abc in the probe event message, like:

Events:
  Type     Reason     Age                   From               Message
  ----     ------     ----                  ----               -------
  Normal   Scheduled  18m                   default-scheduler  Successfully assigned xxx/xxx-controller-manager-7c8fcd5fff-4fprb to cloud-dev
  Normal   Pulling    20m                   kubelet            Pulling image "xxx/xxx/xxx:v0.0.1"
  Normal   Pulled     20m                   kubelet            Successfully pulled image "xxx/xxx/xxx-controller:v0.0.1"
  Normal   Started    20m                   kubelet            Started container manager
  Normal   Created    20m                   kubelet            Created container manager
  Normal   Created    19m (x4 over 20m)     kubelet            Created container kube-rbac-proxy
  Normal   Started    19m (x4 over 20m)     kubelet            Started container kube-rbac-proxy
  ...
  Warning  Unhealthy  2m58s (x31 over 10m)  kubelet            [Container abc] Readiness probe failed: HTTP probe failed with statuscode: 500

Why is this needed?

When there are multiple containers in a pod, we use kubectl describe po xxx to show the events,
it is not showing the failed container name, but it is useful and needed.

Events:
  Type     Reason     Age                   From               Message
  ----     ------     ----                  ----               -------
  Normal   Scheduled  18m                   default-scheduler  Successfully assigned xxx/xxx-controller-manager-7c8fcd5fff-4fprb to cloud-dev
  Normal   Pulling    20m                   kubelet            Pulling image "xxx/xxx/xxx:v0.0.1"
  Normal   Pulled     20m                   kubelet            Successfully pulled image "xxx/xxx/xxx-controller:v0.0.1"
  Normal   Started    20m                   kubelet            Started container manager
  Normal   Created    20m                   kubelet            Created container manager
  Normal   Created    19m (x4 over 20m)     kubelet            Created container kube-rbac-proxy
  Normal   Started    19m (x4 over 20m)     kubelet            Started container kube-rbac-proxy
  ...
  Warning  Unhealthy  2m58s (x31 over 10m)  kubelet            Readiness probe failed: HTTP probe failed with statuscode: 500
@astraw99 astraw99 added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 19, 2024
@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 19, 2024
@astraw99
Copy link
Member Author

/triage accepted
/sig cli

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 19, 2024
@github-project-automation github-project-automation bot moved this to Needs Triage in SIG CLI Dec 19, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Dec 19, 2024
@astraw99 astraw99 linked a pull request Dec 19, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/cli Categorizes an issue or PR as relevant to SIG CLI. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG CLI
Status: Needs Triage
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add container name in the probe event message astraw99/kubernetes
2 participants
@k8s-ci-robot @astraw99