Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[flaky test] [It] [sig-network] Services should implement NodePort and HealthCheckNodePort correctly when ExternalTrafficPolicy changes #129221

Open
antomy-gc opened this issue Dec 14, 2024 · 3 comments
Open

[flaky test] [It] [sig-network] Services should implement NodePort and HealthCheckNodePort correctly when ExternalTrafficPolicy changes #129221

antomy-gc opened this issue Dec 14, 2024 · 3 comments
Labels
kind/flake Categorizes issue or PR as related to a flaky test. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/network Categorizes an issue or PR as relevant to SIG Network.

Comments

@antomy-gc
Copy link

antomy-gc commented Dec 14, 2024 •
edited
Loading

Which jobs are flaking?

pull-kubernetes-e2e-gce:
failed run
succeeded run

on PR [strategicpatch] support duplicated mergeKey values #125932

Which tests are flaking?

Kubernetes e2e suite: [It] [sig-network] Services should implement NodePort and HealthCheckNodePort correctly when ExternalTrafficPolicy changes

Since when has it been flaking?

since my last commit in PR, maybe earlier in the same PR (there was a flaky test in the same PR, but i cant remember which exactly)

Testgrid link

https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/125932/pull-kubernetes-e2e-gce/1867982328341467136

Reason for failure (if possible)

Possibly failing because of changes introduced in PR.

Test log says:

I1214 17:43:45.840527 65508 service.go:4068] Unexpected error: updating ExternalTrafficPolicy and HealthCheckNodePort: 
    <*fmt.wrapError | 0xc00152a9e0>: 
    failed to update Service "external-local-update": Internal error occurred: failed to allocate requested HealthCheck NodePort 31865: provided port is already allocated
    {
        msg: "failed to update Service \"external-local-update\": Internal error occurred: failed to allocate requested HealthCheck NodePort 31865: provided port is already allocated",
        err: <*errors.StatusError | 0xc007ae3540>{
            ErrStatus: {
                TypeMeta: {Kind: "", APIVersion: ""},
                ListMeta: {
                    SelfLink: "",
                    ResourceVersion: "",
                    Continue: "",
                    RemainingItemCount: nil,
                },
                Status: "Failure",
                Message: "Internal error occurred: failed to allocate requested HealthCheck NodePort 31865: provided port is already allocated",
                Reason: "InternalError",
                Details: {
                    Name: "",
                    Group: "",
                    Kind: "",
                    UID: "",
                    Causes: [
                        {
                            Type: "",
                            Message: "failed to allocate requested HealthCheck NodePort 31865: provided port is already allocated",
                            Field: "",
                        },
                    ],
                    RetryAfterSeconds: 0,
                },
                Code: 500,
            },
        },
    }
[FAILED] updating ExternalTrafficPolicy and HealthCheckNodePort: failed to update Service "external-local-update": Internal error occurred: failed to allocate requested HealthCheck NodePort 31865: provided port is already allocated

This PR changes the way elements duplicated by the MergeKey value are handled on patch.
Specifically, ports are such elements, so there are 3 possibilities:

  • these ports are handled incorrectly
  • my changes in PR are unstable and may produce invalid results in some cases

Anything else we need to know?

No response

Relevant SIG(s)

/sig network
@antomy-gc antomy-gc added the kind/flake Categorizes issue or PR as related to a flaky test. label Dec 14, 2024
@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 14, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@aojea
Copy link
Member

aojea commented Dec 17, 2024

Ref #127153

@aojea
Copy link
Member

aojea commented Dec 19, 2024

/cc @danwinship

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/flake Categorizes issue or PR as related to a flaky test. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/network Categorizes an issue or PR as relevant to SIG Network.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aojea @k8s-ci-robot @antomy-gc