Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failure cluster [5c42e849...]: TestApfWatchHandlePanic/post-execute_panic DATA RACE #128962

Open
pohly opened this issue Nov 25, 2024 · 4 comments
Open

Failure cluster [5c42e849...]: TestApfWatchHandlePanic/post-execute_panic DATA RACE #128962

pohly opened this issue Nov 25, 2024 · 4 comments
Assignees
@tkashem
Labels
kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/flake Categorizes issue or PR as related to a flaky test. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@pohly
Copy link
Contributor

pohly commented Nov 25, 2024

Failure cluster 5c42e84947d532cf1eee

The test accesses a variable marked as "atomicRead" without using an atomic read...

kubernetes/staging/src/k8s.io/apiserver/pkg/server/filters/priority-and-fairness_test.go

Line 188 in e4c1f98

if atomicReadOnlyExecuting != 0 {

Most recently touched in #127029. Prior attempts to fix this include #126574, reverted in #127089.

cc @tkashem

Error text:
Failed; Failed
=== RUN   TestApfWatchHandlePanic/post-execute_panic
==================
WARNING: DATA RACE
Read at 0x0000055ea734 by goroutine 5917:
  k8s.io/apiserver/pkg/server/filters.newApfHandlerWithFilter.func2.1.1()
      /home/prow/go/src/k8s.io/kubernetes/staging/src/k8s.io/apiserver/pkg/server/filters/priority-and-fairness_test.go:188 +0x30
  runtime.deferreturn()
...
Previous write at 0x0000055fe734 by goroutine 5974:
  sync/atomic.AddInt32()
      /home/prow/go/src/k8s.io/kubernetes/_output/local/go/cache/mod/golang.org/toolchain@v0.0.1-go1.23.3.linux-amd64/src/runtime/race_amd64.s:281 +0xb
  sync/atomic.AddInt32()
      <autogenerated>:1 +0x14
  k8s.io/apiserver/pkg/server/filters.(*priorityAndFairnessHandler).Handle.func7()
      /home/prow/go/src/k8s.io/kubernetes/staging/src/k8s.io/apiserver/pkg/server/filters/priority-and-fairness.go:206 +0x1a7
  k8s.io/apiserver/pkg/server/filters.(*fakeWatchApfFilter).Handle()

Recent failures:

11/20/2024, 12:40:47 PM ci-kubernetes-unit

/kind failing-test
/kind flake
/sig api-machinery
@k8s-ci-robot k8s-ci-robot added kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/flake Categorizes issue or PR as related to a flaky test. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 25, 2024
@pohly pohly mentioned this issue Nov 25, 2024
Merged
@dims
Copy link
Member

dims commented Nov 25, 2024

cc @liggitt

@liggitt
Copy link
Member

liggitt commented Nov 25, 2024

/assign @tkashem

@BenTheElder
Copy link
Member

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 26, 2024
@liggitt
Copy link
Member

liggitt commented Dec 4, 2024

still seeing this happen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tkashem tkashem

Labels
kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/flake Categorizes issue or PR as related to a flaky test. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@pohly @dims @BenTheElder @liggitt @tkashem @k8s-ci-robot