Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flaking Test] [NodeFeature:SidecarContainers] Containers Lifecycle when A pod with restartable init containers is terminating #128113

Open
pacoxu opened this issue Oct 16, 2024 · 2 comments
Labels
kind/flake Categorizes issue or PR as related to a flaky test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/node Categorizes an issue or PR as relevant to SIG Node. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@pacoxu
Copy link
Member

pacoxu commented Oct 16, 2024

Which jobs are flaking?

29 ci-cos-cgroupv1-containerd-node-e2e-features ►
11 ci-cos-cgroupv2-containerd-node-e2e-features ►
5 ci-cos-containerd-node-e2e-features ►
3 ci-kubernetes-node-swap-fedora ▼

Which tests are flaking?

E2eNode Suite.[It] [sig-node] [NodeFeature:SidecarContainers] Containers Lifecycle when A pod with restartable init containers is terminating when The PreStop hooks don't exit should terminate sidecars simultaneously if prestop doesn't exit

Since when has it been flaking?

NA

Testgrid link

Reason for failure (if possible)

probably those flakes can be fixed by tweak the simulToleration.

const simulToleration = 500 // milliseconds
// should all end together since they loop infinitely and exceed their grace period
gomega.Expect(ps1Last-ps2Last).To(gomega.BeNumerically("~", 0, simulToleration),


Expected
    <int64>: 30708
to be within 1000 of ~
    <int>: 32000
In [It] at: k8s.io/kubernetes/test/e2e_node/container_lifecycle_test.go:3294 @ 10/13/24 19:55:14.386
[FAILED] should delete in < 5 seconds, took 6.112737
Expected
    <float64>: 6.112736517
to be <
    <int64>: 5
In [It] at: k8s.io/kubernetes/test/e2e_node/container_lifecycle_test.go:3548 @ 10/11/24 15:58:43.609

Expected
    <int64>: -912
to be within 500 of ~
    <int>: 0
In [It] at: k8s.io/kubernetes/test/e2e_node/container_lifecycle_test.go:3285 @ 10/15/24 18:03:02.718
}

Anything else we need to know?

No response

Relevant SIG(s)

/sig node
sidecar related

@pacoxu pacoxu added the kind/flake Categorizes issue or PR as related to a flaky test. label Oct 16, 2024
@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Oct 16, 2024
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Oct 16, 2024
@pacoxu pacoxu closed this as completed Oct 16, 2024
@github-project-automation github-project-automation bot moved this from Triage to Done in SIG Node CI/Test Board Oct 16, 2024
@pacoxu pacoxu reopened this Oct 16, 2024
@github-project-automation github-project-automation bot moved this from Done to Triage in SIG Node CI/Test Board Oct 16, 2024
@AnishShah
Copy link
Contributor

/cc @SergeyKanzhelev

@haircommander
Copy link
Contributor

/triage accepted
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/flake Categorizes issue or PR as related to a flaky test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/node Categorizes an issue or PR as relevant to SIG Node. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Status: Issues - In progress
Development

No branches or pull requests

4 participants