Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reduce complexity of email regex in angular dashboard #7595

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: reduce complexity of email regex in angular dashboard #7595

wants to merge 1 commit into from

Conversation

CodeVigilanteOfficial
Copy link

@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign orfeas-k for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot requested review from kimwnasptd and orfeas-k May 31, 2024 11:52
@thesuperzapper thesuperzapper changed the title fix for redos fix: reduce complexity of email regex in angular dashboard Jun 6, 2024
@thesuperzapper
Copy link
Member

@CodeVigilanteOfficial I just want to note that the centraldashboard-angular rewrite is currently unreleased.

However, the normal dashboard uses the same email regex, so might also be susceptible.

In another PR we are planning to update it, but to a different regex, I would appreciate if you could take a look at it, and see if there are any performance concerns.

#7597

@thesuperzapper
Copy link
Member

Also, did this PR accidentally change the line-endings of this file?

Because the GitHub diff is showing the full file as changed.

@thesuperzapper thesuperzapper mentioned this pull request Jun 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimwnasptd kimwnasptd Awaiting requested review from kimwnasptd

@orfeas-k orfeas-k Awaiting requested review from orfeas-k

Assignees
No one assigned
Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CodeVigilanteOfficial @thesuperzapper