-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TRACKING] Kubeflow 1.9.0 (Notebooks WG Components) #7453
Comments
/cc @kubeflow/wg-notebooks-leads @DnPlas |
hey @thesuperzapper, just to check for updates on this, when can we cut the new patch release? We'd like to work on the patch release next week. |
@kimwnasptd it looks like a number of regressions were also introduced in the Kubeflow Notebooks 1.8.0 which MUST be resolved before 1.8.1. All are caused by trying to access parts of a YAML/object that are not defined (causing "key errors" in Python).
|
#7421 might be relevant as well. |
It looks like there is another critical issue with 1.8.0 (and all previous versions): Which causes the Notebook UI to crash loop when a Notebook with a null/empty |
Regarding "WARNING: we might want to consider setting a non-infinite timeout, so that notebooks pods will eventually crash-loop, rather than hanging forever." What about just using one minute as timeout? |
#7325 is what would be useful for 1.9. Even if we just merge a reduced version and improve later on. |
Let's try and put all the open issues (that we plan to fix in 1.9.0) in the milestone I just created, it will make it easier to track: |
Can you add #7325 to https://github.com/kubeflow/kubeflow/milestone/4 |
@juliusvonkohout not for the We can discuss it for |
I have tried to go through every open (human-authored) PR, and group them by component in this issue under the "Future 1.9.1" section. I have created a separate milestone for 1.9.1: https://github.com/kubeflow/kubeflow/milestone/5 WARNING: none are ready to merge, and not all will make it into |
Thank you @thesuperzapper , these Milestones are really helpful not only for you but for others to keep track of the pending work. Other WGs should take inspiration! |
Even merging only the first part for code maintenance without the second set of labels is useful. |
@thesuperzapper @kimwnasptd this one seems to be relavant for your next RC kubeflow/manifests#2752 |
Originally, this issue was tracking a
1.8.1
release, but now that1.9.0
is so close, we will just include them in that.We are planning to do an overall Kubeflow 1.8.1 patch release which will include a number of fixes to issues uncovered/missed in the 1.8.0 release.Missing Stuff
There may have been other critical PRs / Issues raised since we created this issue.
We should review the recent activity
kubeflow/kubeflow
repo before finalizing this list:Other Tracking Issues
Changes for
1.9.0
We need to finish/fix these PRs and then cherry-pick them into the
v1.9-branch
before cutting the1.9.0
tag.Notebook Images
Notebooks/TensorBoards Controller
ISTIO_HOST
in notebook/tensorboard controller for Istio VirtualServices #6902PVC Viewer Controller
Notebook Spawner UI (Jupyter Web App)
get_username
as a string #7457node.status.capacity
#7485get_status_from_container_state()
)status.containerState
messages #7585PVC Viewer UI
Tensorboards Web App
TWA_APP_SECURE_COOKIES
config #7274Central Dashboard
{ns}
template inexternalLinks
#7138All namespaces
in Manage Contributors screen (#7188) #7242DASHBOARD_LINKS_CONFIGMAP
env-var #7264Future Changes for
1.9.1
Repo Cleanup and CI
Notebook Images
kubeflow-katib
andkserve
packages to default notebook images notebooks#122Notebooks Controller
runningCount
andtotalCount
in notebook controller metrics #6838NotebookCullingCount
andNotebookCullingTimestamp
in prometheus metrics #6488Profile Controller
Fixed by: Fix (profile controller): Profile controller fails to update profile owner, fixes #6576 and #5449 #7276Tensorboard Controller
gcr.io/kubebuilder/kube-rbac-proxy
in TensorBoards beforeMarch 18, 2025
dashboard#58Notebook Spawner UI
jupyter-notebook-role
andjupyter-notebook-role-binding
#7616gpusCount
tospawner_ui_config.yaml
#7295memoryVendors
and arbitrary counts for notebook GPU resource limits #6657selector.matchExpression
in PodDefaults #7551matchExpressions
#6983PVC Viewer UI / Controller
Central Dashboard
Admission Webhook (PodDefaults)
PodDefault
configurations
are keyed by their label selector's key, not their name notebooks#121KFAM
Future Changes for
1.10.0
See #7459
The text was updated successfully, but these errors were encountered: