Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TRACKING] Kubeflow 1.9.0 (Notebooks WG Components) #7453

Open
thesuperzapper opened this issue Jan 24, 2024 · 14 comments
Open

[TRACKING] Kubeflow 1.9.0 (Notebooks WG Components) #7453

thesuperzapper opened this issue Jan 24, 2024 · 14 comments
Milestone

Comments

@thesuperzapper
Copy link
Member

thesuperzapper commented Jan 24, 2024

Originally, this issue was tracking a 1.8.1 release, but now that 1.9.0 is so close, we will just include them in that.

We are planning to do an overall Kubeflow 1.8.1 patch release which will include a number of fixes to issues uncovered/missed in the 1.8.0 release.

Missing Stuff

There may have been other critical PRs / Issues raised since we created this issue.

We should review the recent activity kubeflow/kubeflow repo before finalizing this list:

Other Tracking Issues


Changes for 1.9.0

We need to finish/fix these PRs and then cherry-pick them into the v1.9-branch before cutting the 1.9.0 tag.

Notebook Images

Notebooks/TensorBoards Controller

PVC Viewer Controller

Notebook Spawner UI (Jupyter Web App)

PVC Viewer UI

Tensorboards Web App

Central Dashboard


Future Changes for 1.9.1

Repo Cleanup and CI

Notebook Images

Notebooks Controller

Profile Controller

Tensorboard Controller

Notebook Spawner UI

PVC Viewer UI / Controller

Central Dashboard

Admission Webhook (PodDefaults)

KFAM


Future Changes for 1.10.0

See #7459

@thesuperzapper
Copy link
Member Author

/cc @kubeflow/wg-notebooks-leads @DnPlas

@DnPlas
Copy link
Contributor

DnPlas commented Jan 26, 2024

hey @thesuperzapper, just to check for updates on this, when can we cut the new patch release? We'd like to work on the patch release next week.

@thesuperzapper
Copy link
Member Author

@kimwnasptd it looks like a number of regressions were also introduced in the Kubeflow Notebooks 1.8.0 which MUST be resolved before 1.8.1.

All are caused by trying to access parts of a YAML/object that are not defined (causing "key errors" in Python).

@juliusvonkohout
Copy link
Member

#7421 might be relevant as well.

@thesuperzapper
Copy link
Member Author

thesuperzapper commented Feb 15, 2024

It looks like there is another critical issue with 1.8.0 (and all previous versions):

Which causes the Notebook UI to crash loop when a Notebook with a null/empty image is created.

@juliusvonkohout
Copy link
Member

Regarding "WARNING: we might want to consider setting a non-infinite timeout, so that notebooks pods will eventually crash-loop, rather than hanging forever." What about just using one minute as timeout?

@thesuperzapper thesuperzapper pinned this issue Apr 26, 2024
@thesuperzapper thesuperzapper changed the title [TRACKING] Kubeflow 1.8.1 (Notebooks WG Components) [TRACKING] Kubeflow 1.9.0 (Notebooks WG Components) May 7, 2024
@juliusvonkohout
Copy link
Member

juliusvonkohout commented May 8, 2024

#7325 is what would be useful for 1.9. Even if we just merge a reduced version and improve later on.

@thesuperzapper thesuperzapper added this to the v1.9.0 milestone May 9, 2024
@thesuperzapper
Copy link
Member Author

Let's try and put all the open issues (that we plan to fix in 1.9.0) in the milestone I just created, it will make it easier to track:

@juliusvonkohout
Copy link
Member

@thesuperzapper
Copy link
Member Author

Can you add #7325 to https://github.com/kubeflow/kubeflow/milestone/4

@juliusvonkohout not for the 1.9.0 release, we really need to get it moving.

We can discuss it for 1.9.1, but even then, I am not sold that we actually need such a complex solution to a problem which can be solved by just including two copies of the ConfigMap in the manifests (see #7325 (comment)).

@thesuperzapper
Copy link
Member Author

I have tried to go through every open (human-authored) PR, and group them by component in this issue under the "Future 1.9.1" section.

I have created a separate milestone for 1.9.1: https://github.com/kubeflow/kubeflow/milestone/5

WARNING: none are ready to merge, and not all will make it into 1.9.1, but having them grouped should help us review them.

@StefanoFioravanzo
Copy link
Member

Thank you @thesuperzapper , these Milestones are really helpful not only for you but for others to keep track of the pending work. Other WGs should take inspiration!

@juliusvonkohout
Copy link
Member

Can you add #7325 to https://github.com/kubeflow/kubeflow/milestone/4

@juliusvonkohout not for the 1.9.0 release, we really need to get it moving.

We can discuss it for 1.9.1, but even then, I am not sold that we actually need such a complex solution to a problem which can be solved by just including two copies of the ConfigMap in the manifests (see #7325 (comment)).

Even merging only the first part for code maintenance without the second set of labels is useful.

@juliusvonkohout
Copy link
Member

@thesuperzapper @kimwnasptd this one seems to be relavant for your next RC kubeflow/manifests#2752

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To Do
Development

No branches or pull requests

4 participants