Fix launchd killing VMWare process at end of script execution (digita…

…l-asset#6006) * Fix alunchd killing VMWare process at end of script execution * Fix alunchd killing VMWare process at end of script execution CHANGELOG_BEGIN Fix issue with MacOS Catalina Launchd killing VMWare instance on rebuild (AbandonProcessGrop) CHANGELOG_END
kgeonw · May 18, 2020 · be4f85d · be4f85d
1 parent 5d1d1db
commit be4f85d
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/infra/macos/scripts/README.md b/infra/macos/scripts/README.md
@@ -11,6 +11,15 @@ Example script for Launchctl scheduled rebuild of MacOS nodes. Run via
 launctl load com.digitalasset.macos-builder-crontab.plist
 ```
 
+and unload via 
+
+```bash
+launctl unload com.digitalasset.macos-builder-crontab.plist
+```
+
+NOTE: AbandonProcessGroup key is requied for VMWare or the started vmx process is sent a SIGTERM signal by launchd,
+causing node to halt and not be left running at end of script. Different behaviour to VirtualBox.
+
 ## rebuild-crontask.sh
 
 Script called by launchctl job to force destroy and rebuild a VSTS node. Needs a PAT token with job access 
@@ -27,4 +36,4 @@ Helper script to build a node. Called from the above script. Needs a PAT token f
 * Delete GarageBand, iMovie, KeyNote, Pages, Sheets to save space and avoid annoying Update notification
 * May need to download Catalina installer on new release to ensure latest patched version
 * Consider creating SSH key pair and distribute public key to other nodes in authorized_keys to distrbute 
-files more easily 
+files more easily 
diff --git a/infra/macos/scripts/com.digitalasset.macos-builder-crontab.plist b/infra/macos/scripts/com.digitalasset.macos-builder-crontab.plist
@@ -21,6 +21,12 @@
   <key>RunAtLoad</key>
   <false/>
 
+  <key>AbandonProcessGroup</key>
+  <true/>
+
+  <key>RunAtLoad</key>
+  <false/>
+
   <key>StandardErrorPath</key>
   <string>/Users/builder/rebuild-crontab.err</string>