-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Events tab to relevant objects in the UI #34436
Conversation
This will add the events tab if enabled and authorized to:
|
Hi @antikalk, many thanks for this and your previous contribution. We had to change this PR to a draft as we realized that some improvements were necessary after merging your previous PR: #34561. You can view these changes here: #34735 . Now that these improvements are in place, we can proceed with this PR. However, I'd appreciate it if you could review the current implementation of the event tabs for Clients and Users as introduced in #34735 and make any relevant changes to this PR. Let's keep this PR as a draft until it's ready for review. Thanks! |
038c304
to
a6476a8
Compare
@agagancarczyk I have updated the branch to include the changes. During development I noticed two changes:
|
Thanks @antikalk 1. Yes, we should hide the chip. 2. Yes, this behavior makes sense |
22ac4d7
to
3df3619
Compare
@agagancarczyk I provided the change to the filter chips with this PR. |
@antikalk Please fix conflicts. |
3df3619
to
018708f
Compare
@ssilvert done |
@antikalk Sorry. Please fix conflicts again. Will you be addressing the empty state issue I raised? If not, we can do it in another issue/PR. |
Fixes keycloak#29113 Signed-off-by: Oliver Cremerius <antikalk@users.noreply.github.com>
@ssilvert I fixed the conflicts. In my opinion it would make sense to address the empty state issue in a different issue/pr. Any chance of getting this into 26.1? Should we include the feature in the release notes? |
Fixes #29113