Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qgroup: Add new subcommand to set/get drop_subtree_threshold #795

Open
kdave opened this issue May 23, 2024 · 3 comments
Open

qgroup: Add new subcommand to set/get drop_subtree_threshold #795

kdave opened this issue May 23, 2024 · 3 comments
Labels
enhancement

Comments

@kdave
Copy link
Owner

kdave commented May 23, 2024

For convenience we should provide a command to set the threshold, right now it's something like echo 1 > /sys/fs/btrfs/$uuid/qgroups/drop_subtree_threshold where the uuid must be found by other means.

Related note: we also have per-filesystem quota_override, an command may be also good, with unified naming. We have the property command so current suggestion is to set it like that instead of adding set/get command to quota or qgroup.
@realwakka
Copy link
Contributor

Hi, I sent a patch. I would appreciate it if you could review it.
https://lore.kernel.org/linux-btrfs/20240812123103.8460-1-realwakka@gmail.com/

@realwakka
Copy link
Contributor

Is this issue outdated?

@adam900710
Copy link
Collaborator

Kinda of. The upstream kernel now sets a default value 3, which is better than using any user space tool to set an initial value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@adam900710 @kdave @realwakka