Add SFX

kcgidw · May 21, 2020 · 6e6e0b3 · 6e6e0b3
1 parent bc9e98d
commit 6e6e0b3
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 7 deletions.
diff --git a/readme.md b/readme.md
@@ -19,9 +19,9 @@ I'm not actively seeking contributors, but if you have a pull request I'm happy
 Some guidelines:
 
 -   I'm not seeking additional keyword prompts. There's already a lot!
--   UI changes must reasonably accomodate iPhone 5 screens (320x568)
--   FAO is simple, not ambitious. The old Crabhat Spyfall webapp was a huge inspiration for me, and it was pretty minimalistic.
--   As a rule of thumb, I'm hesitant to make changes, additions, or enforcements to the _rules_ of the game. Think of the people with house rules!
+-   UI should accomodate iPhone 5 screens (320x568).
+-   FAO isn't ambitious. The old Crabhat Spyfall webapp was a huge inspiration for me.
+-   As a loose rule of thumb, I'm hesitant to add to or enforce game rules. This is in line with keeping things minimalistic, and also accommodates for players with house rules.
 
 If you have questions, feel free to email me or create a feature request for discussion.
 
@@ -34,3 +34,7 @@ Enjoy the game? Send a tip: [Ko-fi](https://ko-fi.com/krackocloud).
 ## License
 
 GNU General Public License v3.0
+
+## Credits
+
+Notification SFX from [Material.io](https://material.io/design/sound/sound-resources.html) ([CC-BY 4.0](https://creativecommons.org/licenses/by/4.0/))
diff --git a/src/public/js/faq-view.vue b/src/public/js/faq-view.vue
@@ -42,6 +42,12 @@
 						<div class="qa">
 							<h3>Misc. about</h3>
 							<p>FAO is not affiliated with Oink Games.</p>
+							<p>
+								Notification SFX from
+								<a href="https://material.io/design/sound/sound-resources.html"></a>
+								(<a href="https://creativecommons.org/licenses/by/4.0/">CC-BY 4.0</a
+								>)
+							</p>
 							<p>
 								This is a one-man pet project, so I appreciate your patience for
 								fixes and features.

diff --git a/src/public/js/state.js b/src/public/js/state.js
@@ -6,7 +6,7 @@ import { generateClientGameState } from './client-game';
 import { validateUsername } from '../../common/util';
 
 const socket = io();
-// const sfx = new Audio('static/sfx-shake.wav');
+const sfx = new Audio('static/notification_simple-01.wav');
 
 const Store = {
 	state: {
@@ -88,9 +88,9 @@ function handleSocket(messageName, handler, errHandler) {
 				? Store.state.gameState.strokes.length
 				: 0;
 			Store.setGameState(data.roomState);
-			// if (prevStrokesLength < data.roomState.strokes.length) {
-			// sfx.play();
-			// }
+			if (prevStrokesLength < data.roomState.strokes.length) {
+				sfx.play();
+			}
 		}
 	});
 }

diff --git a/src/public/static/notification_simple-01.wav b/src/public/static/notification_simple-01.wav