-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
talek: start adding a talek replica kaetzchen service worker #365
Draft
mixmasala
wants to merge
37
commits into
main
Choose a base branch
from
add_talek_replica
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,582
−546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the monotime package as a monotomic clock is part of golang's builtin time since golang 1.9
TODO: implmement the OnCommand method and command types
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #365 +/- ##
==========================================
- Coverage 47.18% 47.13% -0.05%
==========================================
Files 87 85 -2
Lines 15117 15122 +5
==========================================
- Hits 7133 7128 -5
- Misses 7031 7043 +12
+ Partials 953 951 -2 ☔ View full report in Codecov by Sentry. |
the CBOR ServerPlugin no longer returns a reply, but instead must send responses using the server.Write(Command) API. This means that the mix server will not need to block waiting for a response from the plugin.
…nc send; refactor NewPacketFromSURB server/cborplugin/client: add msgID to Response type server/CBORPluginWorker: refactor NewPacketFromSURB to not depend on origin packet
This makes a pki.Document available internally
…ponse Refactor services to use the server.Write passed by RegisterConsumer to send responses.
….Response This changes cborplugin so that the Request and Response include the NodeDelay specififed for the Provider so that the response may be scheduled to respond within the sending client's expected ETA
this should help prevent disks filling with logfile entries
server: Add talek replica to Makefile
add SPDX license header and BSD 2-Clause license text
-} - type Command interface { Marshal() ([]byte, error) Unmarshal(b []byte) error
This is required so that the mix server can request the plugin parameters at runtime. TODO: The cborplugin socket client and server need to support requesting Parameters via the CBOR plugin.
…r/cborplugin.ServerPlugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: implmement the OnCommand method and command types