Fix click on cancel button

jupyterlab · Mar 1, 2021 · a6ab476 · a6ab476
1 parent c005c19
commit a6ab476
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/components/diff/NotebookCommentDiffWidget.ts b/src/components/diff/NotebookCommentDiffWidget.ts
@@ -4,7 +4,6 @@ import { NotebookDiffModel } from 'nbdime/lib/diff/model';
 import {
   CellDiffWidget,
   MetadataDiffWidget,
-  // MetadataDiffWidget,
   NotebookDiffWidget
 } from 'nbdime/lib/diff/widget';
 import { CHUNK_PANEL_CLASS } from 'nbdime/lib/diff/widget/common';
@@ -127,6 +126,7 @@ export class NotebookCommentDiffWidget extends NotebookDiffWidget {
           thread_ => thread.id === thread_.id
         );
         threads.splice(threadIndex, 1);
+        widget.node.parentElement.removeChild(widget.node);
         widget.dispose();
       }
     });

diff --git a/src/components/diff/plaintext.ts b/src/components/diff/plaintext.ts
@@ -154,6 +154,7 @@ export class PlainTextDiff extends Widget {
           thread_ => thread.id === thread_.id
         );
         this._props.threads.splice(threadIndex, 1);
+        widget.node.parentElement.removeChild(widget.node);
         widget.dispose();
       }
     });