Fix new discussion life cycle on description

jupyterlab · Mar 2, 2021 · 5e41037 · 5e41037
1 parent f5bd606
commit 5e41037
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/components/diff/CommentThread.ts b/src/components/diff/CommentThread.ts
@@ -60,7 +60,7 @@ export class CommentThread extends Panel {
       } else {
         const msg = this._thread.comments[0]
           ? `${this._thread.comments[0].userName} ${this._thread.comments[0].text}`
-          : 'Start a new discussion';
+          : 'Leave a comment';
         const node = generateNode('p', null, msg);
         this.addWidget(new Widget({ node }));
       }

diff --git a/src/components/tab/PullRequestDescriptionTab.tsx b/src/components/tab/PullRequestDescriptionTab.tsx
@@ -116,10 +116,11 @@ export class PullRequestDescriptionTab extends Panel {
                 thread_ => thread.id === thread_.id
               );
               this.threads.splice(threadIndex, 1);
-              this.layout.removeWidget(widget);
+              widget.parent = null;
               widget.dispose();
             }
           });
+
           this.insertWidget(this.widgets.length - 1, widget);
         }
       }