Fix exposing ISignal instead of Signal
#17122
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to jupyterlab! |
jtpio
changed the title
ISignal instead of SignalISignal instead of Signal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Looks like
RestorableSplitPanelwas exposing aSignalinstead ofISignal.Not a big deal since it's privately defined withing the shell. But we can likely still update it so it exposes an
ISignalinstead, to follow the rest of the code base.Code changes
Expose an
ISignalinstead ofSignalfromRestorableSplitPanel.User-facing changes
None
Backwards-incompatible changes
None, since it's private.