Merge pull request litedb-org#2552 from Joy-less/fix-2534

Fix litedb-org#2534
jiuaizxc · Oct 9, 2024 · c4db4ab · c4db4ab
2 parents 391cc93 + f982a3a
commit c4db4ab
Show file tree

Hide file tree

Showing 4 changed files with 153 additions and 160 deletions.
diff --git a/LiteDB.Tests/Engine/Recursion_Tests.cs b/LiteDB.Tests/Engine/Recursion_Tests.cs
@@ -0,0 +1,61 @@
+using System;
+using Xunit;
+
+namespace LiteDB.Tests.Engine;
+
+public class Recursion_Tests
+{
+    [Fact]
+    public void UpdateInFindAll()
+    {
+        Test(collection =>
+        {
+            foreach (BsonDocument document in collection.FindAll())
+            {
+                collection.Update(document);
+            }
+        });
+    }
+    [Fact]
+    public void InsertDeleteInFindAll()
+    {
+        Test(collection =>
+        {
+            foreach (BsonDocument document in collection.FindAll())
+            {
+                BsonValue id = collection.Insert(new BsonDocument());
+                collection.Delete(id);
+            }
+        });
+    }
+    [Fact]
+    public void QueryInFindAll()
+    {
+        Test(collection =>
+        {
+            foreach (BsonDocument document in collection.FindAll())
+            {
+                collection.Query().Count();
+            }
+        });
+    }
+
+    private void Test(Action<ILiteCollection<BsonDocument>> action)
+    {
+        using LiteDatabase database = new(new ConnectionString()
+        {
+            Filename = "Demo.db",
+            Connection = ConnectionType.Shared,
+        });
+
+        ILiteCollection<BsonDocument> accounts = database.GetCollection("Recursion");
+
+        if (accounts.Count() < 3)
+        {
+            accounts.Insert(new BsonDocument());
+            accounts.Insert(new BsonDocument());
+            accounts.Insert(new BsonDocument());
+        }
+        action(accounts);
+    }
+}
diff --git a/LiteDB.Tests/Issues/Issue2534_Tests.cs b/LiteDB.Tests/Issues/Issue2534_Tests.cs
@@ -0,0 +1,30 @@
+using Xunit;
+
+namespace LiteDB.Tests.Issues;
+
+public class Issue2534_Tests
+{
+    [Fact]
+    public void Test() 
+    {
+        using LiteDatabase database = new(new ConnectionString()
+        {
+            Filename = "Demo.db",
+            Connection = ConnectionType.Shared,
+        });
+
+        ILiteCollection<BsonDocument> accounts = database.GetCollection("Issue2534");
+
+        if (accounts.Count() < 3)
+        {
+            accounts.Insert(new BsonDocument());
+            accounts.Insert(new BsonDocument());
+            accounts.Insert(new BsonDocument());
+        }
+
+        foreach (BsonDocument document in accounts.FindAll())
+        {
+            accounts.Update(document);
+        }
+    }
+}
diff --git a/LiteDB.Tests/LiteDB.Tests.csproj b/LiteDB.Tests/LiteDB.Tests.csproj
@@ -29,15 +29,15 @@
   </ItemGroup>
 
   <ItemGroup>
-    <PackageReference Include="FluentAssertions" Version="5.10.2" />
-    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.4.1" />
-    <PackageReference Include="xunit" Version="2.4.2" />
-    <PackageReference Include="xunit.runner.console" Version="2.4.2">
+    <PackageReference Include="FluentAssertions" Version="6.12.1" />
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.11.1" />
+    <PackageReference Include="xunit" Version="2.9.2" />
+    <PackageReference Include="xunit.runner.console" Version="2.9.2">
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
     </PackageReference>
-    <PackageReference Include="xunit.runner.reporters" Version="2.4.2" />
-    <PackageReference Include="xunit.runner.visualstudio" Version="2.4.5">
+    <PackageReference Include="xunit.runner.reporters" Version="2.9.2" />
+    <PackageReference Include="xunit.runner.visualstudio" Version="2.8.2">
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
     </PackageReference>