Two minor optimizations in heavily used code paths.

jisqyv · Nov 30, 2013 · 12646e0 · 12646e0
1 parent f5c46b5
commit 12646e0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/dulwich/pack.py b/dulwich/pack.py
@@ -1182,8 +1182,10 @@ def get_object_at(self, offset):
         and then the packfile can be asked directly for that object using this
         function.
         """
-        if offset in self._offset_cache:
+        try:
             return self._offset_cache[offset]
+        except KeyError:
+            pass
         assert isinstance(offset, long) or isinstance(offset, int),\
                 'offset was %r' % offset
         assert offset >= self._header_size

diff --git a/dulwich/walk.py b/dulwich/walk.py
@@ -143,7 +143,7 @@ def next(self):
             self._pq_set.remove(sha)
             if sha in self._done:
                 continue
-            self._done.add(commit.id)
+            self._done.add(sha)
 
             for parent_id in self._get_parents(commit):
                 self._push(parent_id)