Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split into smaller libraries? #4

Open
holyjak opened this issue Sep 19, 2019 · 1 comment
Open

Split into smaller libraries? #4

holyjak opened this issue Sep 19, 2019 · 1 comment
Assignees

Comments

@holyjak
Copy link

holyjak commented Sep 19, 2019

Hi Jérémie, nice work!

I am looking into integrating Keycloack service to service and user login into an app so I found this. But the number of dependencies scares me and I would prefer to use my existing web library over Yada. I think it would help adoption if you split it into multiple libraries or a library + an example, with minimal dependencies. F.ex. a core, a library for just service to service auth, a Yada-based library/example for auth backend.... I assume most applications will use but not create users, roles, etc. (Not sure if excluding that would limit the dependencies of the app, though). I find it strange to see talltale in production code as it seems to be primarily a test-time library... And perhaps cheshire could be made optional, allowing the user to provide their own edn<>json transformation (based on the libraries/versions they already use)...

Just some ideas :-)

@jgrodziski
Copy link
Owner

Hi Jakub, thanks,

Yes I completely agree, the splitting was in my Todolist :)
For talltale, I use the main code to generate users not really for testing but more for development environment initialization.
Ok I'll have a look to reduce dependencies.
I hope to land the refactoring in the next weeks.

@jgrodziski jgrodziski self-assigned this Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants