You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
However, there's no typing on get_ssh_vendor, which causes mypy to complain about the variable being assigned to another (thought-to-be-incompatible) type:
/my/module.py:92: error:
Incompatible types in assignment (expression has type
[ParamikoSSHVendor] "type", variable has type "type[SubprocessSSHVendor]")
[assignment]
dulwich.client.get_ssh_vendor = ParamikoSSHVendor
^~~~~~~~~~~~~~~~~
Presumably, this should be typed to SSHVendor, given that anything assigned to that attribute needs to implement that class.
The text was updated successfully, but these errors were encountered:
Wtihin dulwich.client, the
get_ssh_vendor
attribute is designed to be overridden by library callers:dulwich/dulwich/client.py
Lines 2104 to 2105 in 1c07def
A common example of this is for using Paramiko, where the ParamikoSSHVendor docs specifically instruct users to change this attribute:
dulwich/dulwich/contrib/paramiko_vendor.py
Lines 24 to 29 in 1c07def
However, there's no typing on
get_ssh_vendor
, which causes mypy to complain about the variable being assigned to another (thought-to-be-incompatible) type:Presumably, this should be typed to
SSHVendor
, given that anything assigned to that attribute needs to implement that class.The text was updated successfully, but these errors were encountered: