Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Serve should ignore .ruby-lsp directory #9612

Open
MichaelCurrin opened this issue Jun 5, 2024 · 1 comment
Open

[Bug]: Serve should ignore .ruby-lsp directory #9612

MichaelCurrin opened this issue Jun 5, 2024 · 1 comment

Comments

@MichaelCurrin
Copy link
Contributor

MichaelCurrin commented Jun 5, 2024 •
edited
Loading

Operating System

WSL

Ruby Version

ruby 3.0.2p107 (2021-07-07 revision 0db68f0233) [x86_64-linux-gnu]

Jekyll Version

jekyll 3.9 and 4.2

GitHub Pages Version

No response

Expected Behavior

The build and serve commands should ignore the hidden directory .ruby-lsp since it is only for assitance in the IDE with Ruby and not for generating content.

The watch feature should also

Current Behavior

I have Ruby LSP extension installed for VS Code and then https://github.com/Shopify/ruby-lsp is running behind that.

The Jekyll watch feature displays a ton of changes to .ruby-lsp directory when I am not making any changes and this makes output noisy. And there's a chance some content like .md files might be picked up incorrectly.

Relevant log output

...
                    .ruby-lsp/vendor/bundle/ruby/3.0.0/gems/rouge-4.2.1/lib/rouge/demos/graphql
                    .ruby-lsp/vendor/bundle/ruby/3.0.0/gems/rouge-4.2.1/lib/rouge/demos/groovy
                    .ruby-lsp/vendor/bundle/ruby/3.0.0/gems/rouge-4.2.1/lib/rouge/demos/hack
       Jekyll Feed: Generating feed for posts
Run in verbose mode to see all warnings.
                    ...done in 0.237940707 seconds.
                    
      Regenerating: 385 file(s) changed at 2024-06-05 07:55:21
                    .ruby-lsp/vendor/bundle/ruby/3.0.0/gems/rouge-4.2.1/lib/rouge/demos/hack
                    .ruby-lsp/vendor/bundle/ruby/3.0.0/gems/rouge-4.2.1/lib/rouge/demos/haml
                    .ruby-lsp/vendor/bundle/ruby/3.0.0/gems/rouge-4.2.1/lib/rouge/demos/handlebars
                    .ruby-lsp/vendor/bundle/ruby/3.0.0/gems/rouge-4.2.1/lib/rouge/demos/haskell
                    .ruby-lsp/vendor/bundle/ruby/3.0.0/gems/rouge-4.2.1/lib/rouge/demos/haxe
...

Code Sample

No response
@MichaelCurrin
Copy link
Contributor Author

Project-specific fix

This works for a specific project.

# _config.yml
exclude:
  - .ruby-lsp

Proposed solution for Jekyll repo

add .ruby-lsp to default excludes

jekyll/lib/jekyll/configuration.rb

Line 255 in 1484c6d

DEFAULT_EXCLUDES = %w(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MichaelCurrin