From 6bbec5444b845f436c01c09f87e2a1f53f9a6730 Mon Sep 17 00:00:00 2001 From: Itamar Turner-Trauring Date: Wed, 27 Mar 2024 11:51:27 -0400 Subject: [PATCH] Remove assertions. --- src/twisted/internet/defer.py | 5 ----- src/twisted/newsfragments/12122.feature | 1 + 2 files changed, 1 insertion(+), 5 deletions(-) create mode 100644 src/twisted/newsfragments/12122.feature diff --git a/src/twisted/internet/defer.py b/src/twisted/internet/defer.py index caafb52210e..3c8a9db09d4 100644 --- a/src/twisted/internet/defer.py +++ b/src/twisted/internet/defer.py @@ -522,9 +522,6 @@ def addCallbacks( if errbackKeywords is None: errbackKeywords = {} # type: ignore[unreachable] - assert callable(callback) - assert callable(errback) - self.callbacks.append( ( (callback, callbackArgs, callbackKeywords), @@ -873,7 +870,6 @@ def callback(self, result: Union[_SelfResultT, Failure]) -> None: @raise AlreadyCalledError: If L{callback} or L{errback} has already been called on this L{Deferred}. """ - assert not isinstance(result, Deferred) self._startRunCallbacks(result) def errback(self, fail: Optional[Union[Failure, BaseException]] = None) -> None: @@ -1552,7 +1548,6 @@ def _cbDeferred( if succeeded == SUCCESS and self.fireOnOneCallback: self.callback((result, index)) # type: ignore[arg-type] elif succeeded == FAILURE and self.fireOnOneErrback: - assert isinstance(result, Failure) self.errback(Failure(FirstError(result, index))) elif self.finishedCount == len(self.resultList): # At this point, None values in self.resultList have been diff --git a/src/twisted/newsfragments/12122.feature b/src/twisted/newsfragments/12122.feature new file mode 100644 index 00000000000..beb57b3e7fd --- /dev/null +++ b/src/twisted/newsfragments/12122.feature @@ -0,0 +1 @@ +``twisted.internet.defer.Deferred`` operations use less CPU. \ No newline at end of file