Remove assertions.

jamestiotio · Mar 27, 2024 · 6bbec54 · 6bbec54
1 parent c709d3f
commit 6bbec54
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 5 deletions.
diff --git a/src/twisted/internet/defer.py b/src/twisted/internet/defer.py
@@ -522,9 +522,6 @@ def addCallbacks(
         if errbackKeywords is None:
             errbackKeywords = {}  # type: ignore[unreachable]
 
-        assert callable(callback)
-        assert callable(errback)
-
         self.callbacks.append(
             (
                 (callback, callbackArgs, callbackKeywords),
@@ -873,7 +870,6 @@ def callback(self, result: Union[_SelfResultT, Failure]) -> None:
         @raise AlreadyCalledError: If L{callback} or L{errback} has already been
             called on this L{Deferred}.
         """
-        assert not isinstance(result, Deferred)
         self._startRunCallbacks(result)
 
     def errback(self, fail: Optional[Union[Failure, BaseException]] = None) -> None:
@@ -1552,7 +1548,6 @@ def _cbDeferred(
             if succeeded == SUCCESS and self.fireOnOneCallback:
                 self.callback((result, index))  # type: ignore[arg-type]
             elif succeeded == FAILURE and self.fireOnOneErrback:
-                assert isinstance(result, Failure)
                 self.errback(Failure(FirstError(result, index)))
             elif self.finishedCount == len(self.resultList):
                 # At this point, None values in self.resultList have been

diff --git a/src/twisted/newsfragments/12122.feature b/src/twisted/newsfragments/12122.feature
@@ -0,0 +1 @@
+``twisted.internet.defer.Deferred`` operations use less CPU.
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		``twisted.internet.defer.Deferred`` operations use less CPU.