Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can the /add endpoint support the to-files parameter #1845

Open
tttlkkkl opened this issue Feb 1, 2023 · 1 comment
Open

Can the /add endpoint support the to-files parameter #1845

tttlkkkl opened this issue Feb 1, 2023 · 1 comment
Labels
effort/days Estimated to take multiple days, but less than a week exp/intermediate Prior experience is likely helpful kind/enhancement A net-new feature or improvement to an existing feature status/deferred Conscious decision to pause or backlog

Comments

@tttlkkkl
Copy link

tttlkkkl commented Feb 1, 2023 •
edited
Loading

Describe the feature you are proposing

The "to-files" parameter is described in the ipfs api document. See https://docs.ipfs.tech/reference/kubo/rpc/#api -v0-add。 However, I found that using this parameter through the/add entry point of the ipfs cluster and the ipfsproxy does not work. It would be useful if you could add support for this parameter. Thank you for your work.
@tttlkkkl tttlkkkl added the need/triage Needs initial labeling and prioritization label Feb 1, 2023
@hsanjuan hsanjuan added kind/enhancement A net-new feature or improvement to an existing feature exp/intermediate Prior experience is likely helpful effort/days Estimated to take multiple days, but less than a week status/deferred Conscious decision to pause or backlog and removed need/triage Needs initial labeling and prioritization labels Mar 3, 2023
@hsanjuan
Copy link
Collaborator

hsanjuan commented Mar 3, 2023

I'm unlikely to add this because cluster does not use the ipfs add endpoint to start with. The pin add endpoint does not support --to-files. We would have to start interacting with MFS directly (something we don't do at all), and the feature would not work if we start embedding IPFS directly (and drop Kubo/MFS). At least that is my thinking now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort/days Estimated to take multiple days, but less than a week exp/intermediate Prior experience is likely helpful kind/enhancement A net-new feature or improvement to an existing feature status/deferred Conscious decision to pause or backlog
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hsanjuan @tttlkkkl