clang: Fix file_exists_and_ownedby return value (#4935)

commit 008ea09 (clang: check header ownership) updates file_exists() to file_exists_and_ownedby(), add verifies onwer, but the return value is different from before, causing problems with the original code. Signed-off-by: Chunsheng Luo <luochunsheng@ustc.edu>
iovisor · Mar 17, 2024 · c00d69c · c00d69c
1 parent 15a2dec
commit c00d69c
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/cc/frontends/clang/kbuild_helper.cc b/src/cc/frontends/clang/kbuild_helper.cc
@@ -143,8 +143,8 @@ int KBuildHelper::get_flags(const char *uname_machine, vector<string> *cflags) {
 static inline int file_exists_and_ownedby(const char *f, uid_t uid)
 {
   struct stat buffer;
-  int ret;
-  if ((ret = stat(f, &buffer)) == 0) {
+  int ret = stat(f, &buffer) == 0;
+  if (ret) {
     if (buffer.st_uid != uid) {
       std::cout << "ERROR: header file ownership unexpected: " << std::string(f) << "\n";
       return -1;