Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE: first draft of tbl_nested_stack() #4

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ddsjoberg
Copy link
Collaborator

@edelarua can you take a look at the functionality here, and we can discuss the details laster this week? Are we missing anything that is needed?

I was thinking that this could be pretty easily incorporated into gtsummary::tbl_stack(), which would then have it added to tbl_strata() as well, where we would define the nesting headers based on the strata levels.


Pre-review Checklist (if item does not apply, mark is as complete)

  • All GitHub Action workflows pass with a ✅
  • PR branch has pulled the most recent updates from master branch: usethis::pr_merge_main()
  • If a bug was fixed, a unit test was added.
  • Code coverage is suitable for any new functions/features (generally, 100% coverage for new code): devtools::test_coverage()
  • Request a reviewer

Reviewer Checklist (if item does not apply, mark is as complete)

  • If a bug was fixed, a unit test was added.
  • Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
  • Code coverage is suitable for any new functions/features: devtools::test_coverage()

When the branch is ready to be merged:

  • Update NEWS.md with the changes from this pull request under the heading "# cards (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • All GitHub Action workflows pass with a ✅
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge" or "Rebase and merge".

@ddsjoberg ddsjoberg requested a review from edelarua January 7, 2025 23:23
Copy link
Contributor

github-actions bot commented Jan 7, 2025


🎉 Thank you for your contribution! Before this PR can be accepted, we require that you read and agree to our Contributor License Agreement.
You can digitally sign the CLA by posting a comment on this Pull Request in the format shown below. This agreement will apply to this PR as well as all future contributions on this repository.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@ddsjoberg ddsjoberg changed the title first draft of tbl_nested_stack() DO NOT MERGE: first draft of tbl_nested_stack() Jan 7, 2025
Copy link
Contributor

@edelarua edelarua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good so far!! We can meet later this week to discuss but it seems to do what we previously talked about :)

@ddsjoberg
Copy link
Collaborator Author

This looks pretty good so far!! We can meet later this week to discuss but it seems to do what we previously talked about :)

Great! Thanks @edelarua ! I'll send an invite for Friday

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants