Fix jashkenas#1310 - off does not skip consecutive events.

ifnotak · May 14, 2012 · 83a24bb · 83a24bb
1 parent 7d8c51a
commit 83a24bb
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/backbone.js b/backbone.js
@@ -126,6 +126,8 @@
         for (i = 0, length = list.length; i < length; i += 2) {
           if (!(callback && list[i] !== callback || context && list[i + 1] !== context)) {
             list.splice(i, 2);
+            i -= 2;
+            length -= 2;
           }
         }
       }

diff --git a/test/events.js b/test/events.js
@@ -190,4 +190,12 @@ $(document).ready(function() {
     ok(obj.off('event') === obj);
   });
 
+  test("#1310 - off does not skip consecutive events", 0, function() {
+    var obj = _.extend({}, Backbone.Events);
+    obj.on('event', function() { ok(false); }, obj);
+    obj.on('event', function() { ok(false); }, obj);
+    obj.off(null, null, obj);
+    obj.trigger('event');
+  });
+
 });