Refactor

hupe1980 · Jul 30, 2023 · 4c78367 · 4c78367
1 parent da4621e
commit 4c78367
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/agent/executor.go b/agent/executor.go
@@ -51,7 +51,7 @@ func NewExecutor(agent schema.Agent, tools []schema.Tool) (*Executor, error) {
 
 // Call executes the AgentExecutor chain with the given context and inputs.
 // It returns the outputs of the chain or an error, if any.
-func (e Executor) Call(ctx context.Context, values schema.ChainValues, optFns ...func(o *schema.CallOptions)) (schema.ChainValues, error) {
+func (e Executor) Call(ctx context.Context, inputs schema.ChainValues, optFns ...func(o *schema.CallOptions)) (schema.ChainValues, error) {
 	opts := schema.CallOptions{
 		CallbackManger: &callback.NoopManager{},
 	}
@@ -60,7 +60,7 @@ func (e Executor) Call(ctx context.Context, values schema.ChainValues, optFns ..
 		fn(&opts)
 	}
 
-	inputs, err := inputsToString(values)
+	strInputs, err := inputsToString(inputs)
 	if err != nil {
 		return nil, err
 	}
@@ -72,7 +72,7 @@ func (e Executor) Call(ctx context.Context, values schema.ChainValues, optFns ..
 		case <-ctx.Done():
 			return nil, ctx.Err()
 		default:
-			actions, finish, err := e.agent.Plan(ctx, steps, inputs)
+			actions, finish, err := e.agent.Plan(ctx, steps, strInputs)
 			if err != nil {
 				return nil, err
 			}

diff --git a/evaluation/context_qa_eval_chain.go b/evaluation/context_qa_eval_chain.go
@@ -75,14 +75,14 @@ func NewContextQAEvalChain(llm schema.LLM, optFns ...func(o *ContextQAEvalChainO
 }
 
 func (eval *ContextQAEvalChain) Evaluate(ctx context.Context, examples, predictions []map[string]string) ([]schema.ChainValues, error) {
-	inputs := []schema.ChainValues{}
+	inputs := make([]schema.ChainValues, len(examples))
 
 	for i, example := range examples {
-		inputs = append(inputs, schema.ChainValues{
+		inputs[i] = schema.ChainValues{
 			"query":   example[eval.questionKey],
 			"context": example[eval.contextKey],
 			"result":  predictions[i][eval.predictionKey],
-		})
+		}
 	}
 
 	return golc.BatchCall(ctx, eval.llmChain, inputs)

diff --git a/evaluation/qa_eval_chain.go b/evaluation/qa_eval_chain.go
@@ -68,14 +68,14 @@ func NewQAEvalChain(llm schema.LLM, optFns ...func(o *QAEvalChainOptions)) (*QAE
 }
 
 func (eval *QAEvalChain) Evaluate(ctx context.Context, examples, predictions []map[string]string) ([]schema.ChainValues, error) {
-	inputs := []schema.ChainValues{}
+	inputs := make([]schema.ChainValues, len(examples))
 
 	for i, example := range examples {
-		inputs = append(inputs, schema.ChainValues{
+		inputs[i] = schema.ChainValues{
 			"query":  example[eval.questionKey],
 			"answer": example[eval.answerKey],
 			"result": predictions[i][eval.predictionKey],
-		})
+		}
 	}
 
 	return golc.BatchCall(ctx, eval.llmChain, inputs)