Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Dockerfile to use devel image for compatibility #2848

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Update Dockerfile to use devel image for compatibility #2848

wants to merge 5 commits into from

Conversation

YaserJaradeh
Copy link

@YaserJaradeh YaserJaradeh commented Dec 16, 2024 •
edited
Loading

What does this PR do?

The TGI server fails to start due to missing Python headers during the compilation of Triton indexing kernels. The solution is to change the base image to nvidia/cuda:12.4.1-devel-ubuntu22.04 to match the builder image, ensuring the necessary headers are included.
This change increases the image size but resolves the startup issue.

Fixes # (issue)
This pull request addresses the issue #2838

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

@YaserJaradeh
Copy link
Author

@Narsil

KreshLaDoge

This comment was marked as outdated.

Sign in to view

@YaserJaradeh YaserJaradeh mentioned this pull request Jan 13, 2025
Open
4 tasks
@scriptator
Copy link

This PR solves my issue descibed here, thank you!

@scriptator
Copy link

I just noticed that you changed the implementation between me building the image and my previous message. Should I test again?

@YaserJaradeh
Copy link
Author

I just noticed that you changed the implementation between me building the image and my previous message. Should I test again?

Not yet! still broken I just pushed to try to build it on my server but so far it is not working! will ping you when it is 💯

@YaserJaradeh
Copy link
Author

YaserJaradeh commented Jan 13, 2025 •
edited
Loading

@KreshLaDoge I tried multiple variants of using only python3.11-dev but that didn't work! I also tried copying the headers and libraries from the pytorch building stage into the final image and that didn't work either. Furthermore, I tried with a combination of python3.11-dev, cuda command line tools, and build-essential and also I wasn't able to get working!

Any ideas about how to get it to work, or reduce the size of the final image?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KreshLaDoge KreshLaDoge KreshLaDoge requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YaserJaradeh @scriptator @KreshLaDoge